Skip to content

Niamh Madden - HTML - CSS Week 2#275

Closed
niamhmadden23 wants to merge 1 commit into
CodeYourFuture:masterfrom
niamhmadden23:master
Closed

Niamh Madden - HTML - CSS Week 2#275
niamhmadden23 wants to merge 1 commit into
CodeYourFuture:masterfrom
niamhmadden23:master

Conversation

@niamhmadden23
Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

Comment thread css/style.css
padding: 12rem;
}

.hero h1 {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good use of tag h1

Comment thread css/style.css
justify-content: space-between;
}

/* Main */
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structured header, main, and footer.

Comment thread index.html
<body>

<!-- Add your HTML markup here -->
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semantic HTML used

Comment thread index.html
<h2>Everyone needs a little Karma</h2>
<div class="icons">
<div class="icon">
<img src="img/icon-devices.svg" alt="Devices" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All images are in img folder ;) Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants