This repository was archived by the owner on Oct 2, 2024. It is now read-only.
North West 4- Anza Azam -HTML/CSS Week 1#5
Open
Anza-Azam wants to merge 8 commits into
Open
Conversation
Author
|
Fished off with flex usage |
KarenPudner
reviewed
May 29, 2021
| </div> | ||
| <div class="card"> | ||
| <h4>Youth and young adults</h4> | ||
| <a href="" target="_blank">Find out More</a> |
There was a problem hiding this comment.
Good - "target="_blank" is correct. You could also add rel="noopener", although that's not really necessary on trusted links. But it's useful to know (you can read more about it here https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noopener)
KarenPudner
approved these changes
May 29, 2021
KarenPudner
left a comment
There was a problem hiding this comment.
Great work! You have covered everything that was required and you resulting webpage looks good.
KarenPudner
reviewed
May 29, 2021
| } | ||
| button:focus{ | ||
|
|
||
| background-color:blue; |
KarenPudner
reviewed
May 29, 2021
|
|
||
| .introduction { | ||
| background-color: white; | ||
| line-height: 2.5; |
There was a problem hiding this comment.
The instructions say that most of the text on the page is too close together, so maybe add line-height:2.5 to * or body
Author
There was a problem hiding this comment.
thank you Karen, I've now added line-height:2.5 to *
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zoo CSS Challenges attempt.
Modified website with changes.