This repository was archived by the owner on Oct 2, 2024. It is now read-only.
London 10 Maksim Lukianenko HTML-CSS-Challenges Week 2 #231
Open
maxbmaapc wants to merge 5 commits into
Open
Conversation
Author
|
Note that the date span is fixed. As for requirements I can't use JS to make it live. |
Member
There was a problem hiding this comment.
Really amazing work, @Mpanasetckiy . I'm really excited to see this from you.
I've made a zillion comments, because I think you might really benefit from thinking more deeply about front end design in this way. If it seems overwhelming, come back to this later. Some general themes:
- you can do a lot less and get a more robust layout
- don't size components, add them to parents and size the highest level parent you can
- in general, don't explicitly size things, set minimums and let the content flow
- every time you write a layout, test, refactor, and see how much you can remove
Thanks so much for your hard work here. ⭐
Oh and stop using git add . to commit your work. You've committed a load of junk and you will really get in a mess when you accidentally commit 5,000 node modules by doing this. Commit each file deliberately -- always know what code you are adding to a codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.