Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

London 10 Maksim Lukianenko HTML-CSS-Challenges Week 2 #231

Open
maxbmaapc wants to merge 5 commits into
CodeYourFuture:mainfrom
maxbmaapc:main
Open

London 10 Maksim Lukianenko HTML-CSS-Challenges Week 2 #231
maxbmaapc wants to merge 5 commits into
CodeYourFuture:mainfrom
maxbmaapc:main

Conversation

@maxbmaapc

Copy link
Copy Markdown

No description provided.

@maxbmaapc maxbmaapc changed the title London 10 Maksim Lukianenko HTML-CSS-Challenges Week 4 London 10 Maksim Lukianenko HTML-CSS-Challenges Week 2 Feb 15, 2023
@maxbmaapc

Copy link
Copy Markdown
Author

Note that the date span is fixed. As for requirements I can't use JS to make it live.

@SallyMcGrath SallyMcGrath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work, @Mpanasetckiy . I'm really excited to see this from you.

I've made a zillion comments, because I think you might really benefit from thinking more deeply about front end design in this way. If it seems overwhelming, come back to this later. Some general themes:

  • you can do a lot less and get a more robust layout
  • don't size components, add them to parents and size the highest level parent you can
  • in general, don't explicitly size things, set minimums and let the content flow
  • every time you write a layout, test, refactor, and see how much you can remove

Thanks so much for your hard work here. ⭐

Oh and stop using git add . to commit your work. You've committed a load of junk and you will really get in a mess when you accidentally commit 5,000 node modules by doing this. Commit each file deliberately -- always know what code you are adding to a codebase.

Comment thread Form-Controls/styles.css
Comment thread Form-Controls/styles.css Outdated
Comment thread Form-Controls/styles.css Outdated
Comment thread Form-Controls/styles.css Outdated
Comment thread Form-Controls/styles.css Outdated
Comment thread Form-Controls/index.html Outdated
Comment thread Form-Controls/index.html
Comment thread Form-Controls/index.html Outdated
Comment thread Form-Controls/index.html
Comment thread Form-Controls/styles.css Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants