London10-Bedrije Omuri -HTML-CSS- Week II#230
Conversation
SallyMcGrath
left a comment
There was a problem hiding this comment.
Nice work @Bedi06!
Thanks for your hard work here. I can see you've put some effort in. 💪 The Lighthouse score is 100.
I have made a few comments and asked a few questions. Take a look and have a think. Good luck!
|
|
||
| <label for="delivery-date">When do you want it Delivered:</label> | ||
| <input type="date" id="delivery-date" name="delivery-date" required | ||
| min="{{ today | date: "%Y-%m-%d" }}" max="{{ fourWeeksLater | date: |
There was a problem hiding this comment.
| min="{{ today | date: "%Y-%m-%d" }}" max="{{ fourWeeksLater | date: | |
| min="{{ today | date: "%Y-%m-%d" }}" max="{{ fourWeeksLater | date: |
This doesn't seem like HTML code. When you tested your code, did this limit the booking window to four weeks?
(I don't think it can have. Can you talk through your approach?)
There was a problem hiding this comment.
No actually , it didn't.
I doesn't work unless using a server side language, i will make sure to remove it, thank you Sally
| min="{{ today | date: "%Y-%m-%d" }}" max="{{ fourWeeksLater | date: | ||
| "%Y-%m-%d" }}" /> | ||
|
|
||
| <div class="error" id="error"></div> |
There was a problem hiding this comment.
| <div class="error" id="error"></div> | |
What is the purpose of this div? Have you copy pasted code from somewhere else?
| id="name" | ||
| name="name" | ||
| required | ||
| pattern="[a-zA-Z ]{3,}" |
There was a problem hiding this comment.
Do the requirements ask for 3 characters?
| h2 { | ||
| text-align: center; | ||
| } | ||
| input[type="text"], |
There was a problem hiding this comment.
Why have you applied this style to the text and select, but not the email input? Can you talk through your decision there?
| border-radius: 10px; | ||
| } | ||
|
|
||
| .error { |
There was a problem hiding this comment.
Where is this style applied?
| } | ||
| label { | ||
| font-weight: bold; | ||
| margin-bottom: 10px; |
There was a problem hiding this comment.
What would happen if you removed all these padding and margin rules and just used the gap property on the parent?
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Order you T-shirt here!</h1> |
There was a problem hiding this comment.
| <h1>Order you T-shirt here!</h1> | |
| <h1>Order your T-shirt here!</h1> |
| <option value="" disabled selected>Choose a color</option> | ||
| <option value="black">Black</option> | ||
| <option value="white">White</option> | ||
| <option value="beinge">Beinge</option> |
There was a problem hiding this comment.
| <option value="beinge">Beinge</option> | |
| <option value="beige">Beige</option> |
You can, and should, install a spellchecker in VSCode.
No description provided.