Emeka - HTML-CSS-Challenges - WM4#224
Conversation
SallyMcGrath
left a comment
There was a problem hiding this comment.
Thanks for this, @Emeka1993 ! I really appreciate the effort you've put in here.
Thinking a bit more strategically about using this exercise to develop your own learning, how might you go back now and revise your code?
Some things to consider:
Are you happy with this design? Would you put this in your professional portfolio? If not, why not, and what will you do about it?
What would you like to learn more about, of the things discussed in this review? What is your plan to develop that expertise?
What did you learn from this exercise already, and what part of your code are you particularly pleased with?
And lastly, what did you learn from reading Zaw's PR and review that you put into practice here?
| </form> | ||
|
|
||
| <form> | ||
| <label for="Fullname">Full Name:</label> |
There was a problem hiding this comment.
When you ran Lighthouse, what did it say about this line?
| </select> | ||
|
|
||
| <label for="date">Collection Date:</label> | ||
| <input type="date" id="date" name="date" min="<?php echo date('Y-m-d', strtotime('+4 weeks')); ?>" required> |
There was a problem hiding this comment.
I appreciate the innovation @Emeka1993 ;)
But does this line meet all the requirements as stated in the readme?
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h2>Emeka</h2> |
| border-radius: 10px; | ||
| background-color: white; | ||
| margin: 0 auto; | ||
| width: 50%; |
There was a problem hiding this comment.
50% of what?
What size would this be on a 340px iPhone 5?
| cursor: pointer; | ||
| } | ||
| input[type="submit"]:hover { | ||
| background-color: green; |
There was a problem hiding this comment.
What would happen if a user was accessing this without a mouse?
|
|
||
| input[type="submit"] { | ||
| width: 100%; | ||
| background-color: orange; |
There was a problem hiding this comment.
When you ran Lighthouse, what did it say about this line?
No description provided.