NW5-Manchester-Zaw Khing-HTML-CSS-challenges#222
Conversation
SallyMcGrath
left a comment
There was a problem hiding this comment.
Thanks for this, @zkhing ! I really appreciate the effort you've put in here.
Thinking a bit more strategically about using this exercise to develop your own learning, how might you go back now and revise your code?
Some things to consider:
- Are you happy with this design? Would you put this in your professional portfolio? If not, why not, and what will you do about it?
- What would you like to learn more about, of the things discussed in this review? What is your plan to develop that expertise?
- What did you learn from this exercise already, and what part of your code are you particularly pleased with? (I thought your coverage score was impressive!)
| <form> | ||
| <!-- write your html here--> | ||
| <!-- try writing out the requirements first--> | ||
| <div> |
There was a problem hiding this comment.
Is there another sectioning element specifically for forms?
How else might you group a set of fields inside a form, and what is the effect of using a different element?
| </div> | ||
|
|
||
| </html> No newline at end of file | ||
| <div> |
There was a problem hiding this comment.
Is there another element you could have chosen to use instead? Why does it matter how we group form controls?
| <option value="m">M</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XL</option></select |
There was a problem hiding this comment.
Psst, here, the value is xxl but the option text says XL
There was a problem hiding this comment.
Thank you for your review Sally. I know it is silly mistake and I was rushing a bit :) I will take extra care in future.
| /><br /> | ||
| </div> | ||
|
|
||
| <input type="submit" value="Submit" /> |
There was a problem hiding this comment.
Sometimes people use button and sometimes people use input submit. What is the difference and how do you decide which to use?
| value="red" | ||
| checked | ||
| /> | ||
| <label for="red">Red</label><br /> |
There was a problem hiding this comment.
Some things to consider:
- Is a br tag a good idea here?
- Do we ever use html for layout only?
- In our discussions with Lucy, what has she said about br tags?
| h2{ | ||
| text-align: center; | ||
| color: #354f52; | ||
| font-size: 12px; |
There was a problem hiding this comment.
(Don't use font sizes less than 16px for most things.)
Are pixel sizes the best choice for fonts? I think this lesson would be good for you to explore
| id="name" | ||
| name="name" | ||
| pattern="[a-zA-Z\s]+" | ||
| minlength="2" |
|
|
||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>Created by Zaw Khing</h2> |
|
|
||
| .product-form{ | ||
| background-color: #588157; | ||
| margin: 0px 10em; |
There was a problem hiding this comment.
How does em sizing function? What would happen if a user was using this page at 200% text size?
| padding: 10px 20px; | ||
| } | ||
|
|
||
| #size{ |
There was a problem hiding this comment.
Do you need an id here? How did you decide to use an id? Thinking through this decision carefully is useful. You might like this article to help you deliberate. https://csswizardry.com/2011/09/when-using-ids-can-be-a-pain-in-the-class/
No description provided.