Skip to content

Simplify and fix flaky test #102128

Merged
rschu1ze merged 3 commits intoClickHouse:masterfrom
Ergus:Fix_101913
Apr 9, 2026
Merged

Simplify and fix flaky test #102128
rschu1ze merged 3 commits intoClickHouse:masterfrom
Ergus:Fix_101913

Conversation

@Ergus
Copy link
Copy Markdown
Member

@Ergus Ergus commented Apr 8, 2026 •
edited
Loading

The test 02346_text_index_bug101913 is flaky due to a completely different problem in deserialized ConstColumns and how has*Token function checks for emptiness.

Will be fixed in a different PR: #102130
This could avoid reversion in: #102108
And solves the exposed problem with new test 02346_text_index_bug101913 from #101939 fixing #101913

The test was flaky due to a completely independent issue in has*Token function checks for emptiness in deserialized distributed ConstColumns.

Fix: #101913

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@Ergus
Simplify and fix flaky test
c2e6d0f 
The issue source is related with a different issue in deserialized ConstColumns.
Will be fixed in a different PR.
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Apr 8, 2026 •
edited by rschu1ze
Loading

Workflow [PR], commit [124d1ac]

Summary: ❌

job_name test_name status info comment
Stress test (arm_tsan) failure
Hung check failed, possible deadlock found FAIL cidb, issue ISSUE EXISTS

AI Review

Summary

This PR fixes repeated text-index DAG optimization by pre-populating the virtual-column cache from existing DAG inputs, preventing duplicate re-addition of the same virtual input and corresponding LOGICAL_ERROR in repeated passes. It also adds a focused stateless regression test covering both WHERE and PREWHERE on a Merge table. I did not find correctness, safety, concurrency, or performance regressions in the changed code.

Missing context
  • ⚠️ Praktika job reports/logs were not available in this environment, so runtime/cluster-level validation could not be independently confirmed.
ClickHouse Rules
Item Status Notes
Deletion logging ➖
Serialization versioning ➖
Core-area scrutiny ✅
No test removal ✅
Experimental gate ➖
No magic constants ✅
Backward compatibility ✅
SettingsChangesHistory.cpp ➖
PR metadata quality ✅
Safe rollout ✅
Compilation time ✅
No large/binary files ✅
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 8, 2026
@Ergus Ergus mentioned this pull request Apr 8, 2026
Open
1 task
@rschu1ze rschu1ze self-assigned this Apr 8, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Apr 9, 2026

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.10% 84.00% -0.10%
Functions 90.90% 90.90% +0.00%
Branches 76.60% 76.50% -0.10%

Changed lines: 100.00% (7/7) · Uncovered code

Full report · Diff report

@rschu1ze rschu1ze added this pull request to the merge queue Apr 9, 2026
Merged via the queue into ClickHouse:master with commit 103a245 Apr 9, 2026
161 of 163 checks passed
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 9, 2026
@Ergus Ergus mentioned this pull request Apr 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees

@rschu1ze rschu1ze

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

full-text index direct-read throws error when multiple filters used on a merged, distributed table

3 participants

@Ergus @rschu1ze @robot-ch-test-poll1