Skip to content

fix(ci): skip auto-review on maintainer PRs; empty reply is a no-op - #67

Merged
Carl723000 merged 1 commit into
ClaudeCodeUsage:mainfrom
Carl723000:ci/bot-maintainer-skip
Jul 4, 2026
Merged

Carl723000 merged 1 commit into
ClaudeCodeUsage:mainfrom
Carl723000:ci/bot-maintainer-skip

Conversation

@Carl723000

Copy link
Copy Markdown
Collaborator

Follow-up to #66.

Problem (seen on #66): the PR first-pass fires on any non-bot PR — including a maintainer's own finished PR — and on #66 it failed with Empty model reply on the large self-referential diff, leaving a red ✗ check for no reason.

Fixes

  1. Skip maintainer PRs — the if: now also requires the PR author to not be OWNER / MEMBER / COLLABORATOR. Auto first-pass is for external-contributor PRs; a maintainer's completed PR doesn't need it. (Issue auto-triage is unchanged.)
  2. Empty reply → no-op — first-pass.mjs now exits 0 (with a warning) instead of failing when the model returns no text, so a benign blank response doesn't mark the check failed.

No behaviour change when enabled for a contributor PR with a normal reply.

… as a no-op

- The PR first-pass now SKIPS pull requests authored by OWNER / MEMBER /
  COLLABORATOR — a maintainer's own finished PR doesn't need an auto first-pass
  (that review is for external contributors). ClaudeCodeUsage#66 showed it firing on our own
  PR and failing on the big self-referential diff.
- An empty model reply is now a soft no-op (exit 0) instead of a hard failure,
  so a benign blank response doesn't leave a red check on the PR/issue.

Co-Authored-By: Claude <noreply@anthropic.com>
@Carl723000
Carl723000 requested a review from jack21 as a code owner July 4, 2026 18:17
@github-actions github-actions Bot added ci CI / workflow change fix Patch — bug fix labels Jul 4, 2026
@Carl723000
Carl723000 merged commit 947ce32 into ClaudeCodeUsage:main Jul 4, 2026
2 of 3 checks passed
@Carl723000
Carl723000 deleted the ci/bot-maintainer-skip branch August 24, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI / workflow change fix Patch — bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant