Skip to content

Fix #690: Apply clang-format consistently with CI #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lefticus merged 9 commits into from
Apr 18, 2026
Merged

Fix #690: Apply clang-format consistently with CI #691

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65cf24b
Fix #690: Apply clang-format consistently with CI
leftibot Apr 15, 2026
d2f1b61
Address review: fix auto-clang-format detached HEAD error
leftibot Apr 15, 2026
5fc11e6
Remove ref option from checkout step
lefticus Apr 15, 2026
83873a3
Address review: restore ref option to fix detached HEAD in auto-clang…
leftibot Apr 15, 2026
ae408ce
Modify checkout ref handling in auto-clang-format.yml
lefticus Apr 15, 2026
0415910
Address review: fix auto-clang-format checkout for fork PRs
leftibot Apr 15, 2026
4ce9577
Address review: run auto-clang-format on push to develop/master inste…
leftibot Apr 15, 2026
7c5e4b2
Address review: update .clang-format for short expressions on one line
leftibot Apr 15, 2026
8b9cd41
Address review: exclude unittests/catch.hpp from clang-format and rev…
leftibot Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review: run auto-clang-format on push to develop/master inste… 
…ad of PRs

The workflow cannot push back to fork branches, so running on pull_request
was fundamentally broken for fork PRs. Changed trigger to push on develop
and master branches, and simplified checkout (no fork-specific options needed).

Requested by @lefticus in PR #691 review.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
  • Loading branch information
@leftibot @claude
leftibot and claude committed Apr 15, 2026
commit 4ce9577654be4b7476f42c65c0af0d38f83ba93c
10 changes: 5 additions & 5 deletions .github/workflows/auto-clang-format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
name: auto-clang-format
on: [pull_request]
on:
push:
branches:
- develop
- master

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}
fetch-depth: 0
- uses: DoozyX/clang-format-lint-action@v0.20
with:
source: '.'
Expand Down
Loading