Fix #206: Supporting of std::wstring#684
Open
leftibot wants to merge 2 commits into
Open
Conversation
Add a StringType template parameter (defaulting to std::string) to ChaiScript_Parser, Bootstrap::bootstrap(), and Std_Lib::library(), flowing through to the ChaiScript_Impl convenience class. This allows users to instantiate ChaiScript with std::wstring (via ChaiScript_WString) or other string types. String literals, escape sequences (including unicode for wide chars via if constexpr), to_string conversions, and string operations all respect the parameterized type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lefticus
reviewed
Apr 14, 2026
| namespace chaiscript { | ||
| class Std_Lib { | ||
| public: | ||
| template<typename StringType = std::string> |
Member
There was a problem hiding this comment.
@leftibot don't default the newly added template parameters
…ters Remove `= std::string` defaults from the StringType template parameter on ChaiScript_Parser, Bootstrap::bootstrap(), Std_Lib::library(), and ChaiScript_Impl. All call sites now specify the string type explicitly. Requested by @lefticus in PR ChaiScript#684 review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Addressed review feedback from @lefticus. New commits: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by @leftibot.
What changed
Files
Closes #206
Triggered by @lefticus.