Skip to content

Fix #61: Thoroughly test throwing of exceptions from various contexts #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lefticus merged 1 commit into from
Apr 14, 2026
Merged

Fix #61: Thoroughly test throwing of exceptions from various contexts #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions include/chaiscript/language/chaiscript_eval.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,6 +1305,7 @@ namespace chaiscript {

Boxed_Value handle_exception(const chaiscript::detail::Dispatch_State &t_ss, const Boxed_Value &t_except) const {
Boxed_Value retval;
bool handled = false;

size_t end_point = this->children.size();
if (this->children.back()->identifier == AST_Node_Type::Finally) {
Expand All @@ -1318,6 +1319,7 @@ namespace chaiscript {
if (catch_block.children.size() == 1) {
// No variable capture
retval = catch_block.children[0]->eval(t_ss);
handled = true;
break;
} else if (catch_block.children.size() == 2 || catch_block.children.size() == 3) {
const auto name = Arg_List_AST_Node<T>::get_arg_name(*catch_block.children[0]);
Expand All @@ -1331,17 +1333,19 @@ namespace chaiscript {
if (catch_block.children.size() == 2) {
// Variable capture
retval = catch_block.children[1]->eval(t_ss);
handled = true;
break;
}
}
} else {
if (this->children.back()->identifier == AST_Node_Type::Finally) {
this->children.back()->children[0]->eval(t_ss);
}
throw exception::eval_error("Internal error: catch block size unrecognized");
}
}

if (!handled) {
throw;
}

return retval;
}

Expand All @@ -1351,17 +1355,19 @@ namespace chaiscript {
chaiscript::eval::detail::Scope_Push_Pop spp(t_ss);

try {
retval = this->children[0]->eval(t_ss);
} catch (const exception::eval_error &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (const std::runtime_error &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (const std::out_of_range &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (const std::exception &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (Boxed_Value &e) {
retval = handle_exception(t_ss, e);
try {
retval = this->children[0]->eval(t_ss);
} catch (const exception::eval_error &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (const std::runtime_error &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (const std::out_of_range &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (const std::exception &e) {
retval = handle_exception(t_ss, Boxed_Value(std::ref(e)));
} catch (Boxed_Value &e) {
retval = handle_exception(t_ss, e);
}
} catch (...) {
if (this->children.back()->identifier == AST_Node_Type::Finally) {
this->children.back()->children[0]->eval(t_ss);
Expand Down
188 changes: 188 additions & 0 deletions unittests/compiled_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,3 +1782,191 @@ TEST_CASE("eval_error with AST_Node_Trace call stack compiles in C++20") {
(void)stack;
}
}

TEST_CASE("C++ runtime_error thrown from registered function is catchable in ChaiScript") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

chai.add(chaiscript::fun([]() -> int { throw std::runtime_error("cpp_runtime_error"); }), "cpp_throw_runtime");

CHECK(chai.eval<bool>(R"(
var caught = false
try {
cpp_throw_runtime()
}
catch(e) {
caught = true
}
caught
)") == true);
}

TEST_CASE("C++ out_of_range thrown from registered function is catchable in ChaiScript") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

chai.add(chaiscript::fun([]() -> int { throw std::out_of_range("cpp_out_of_range"); }), "cpp_throw_oor");

CHECK(chai.eval<bool>(R"(
var caught = false
try {
cpp_throw_oor()
}
catch(e) {
caught = true
}
caught
)") == true);
}

TEST_CASE("C++ logic_error thrown from registered function is catchable in ChaiScript") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

chai.add(chaiscript::fun([]() -> int { throw std::logic_error("cpp_logic_error"); }), "cpp_throw_logic");

CHECK(chai.eval<bool>(R"(
var caught = false
try {
cpp_throw_logic()
}
catch(e) {
caught = true
}
caught
)") == true);
}

TEST_CASE("ChaiScript throw(int) propagates as Boxed_Value to C++") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

try {
chai.eval("throw(42)");
REQUIRE(false);
} catch (chaiscript::Boxed_Value &bv) {
CHECK(chaiscript::boxed_cast<int>(bv) == 42);
}
}

TEST_CASE("ChaiScript throw(string) propagates as Boxed_Value to C++") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

try {
chai.eval(R"(throw("error msg"))");
REQUIRE(false);
} catch (chaiscript::Boxed_Value &bv) {
CHECK(chaiscript::boxed_cast<std::string>(bv) == "error msg");
}
}

TEST_CASE("Typed catch with no match propagates exception") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

CHECK_THROWS_AS(chai.eval(R"(
try {
throw(42)
}
catch(string e) {
// wrong type, should not match
}
)"), chaiscript::Boxed_Value);
}

TEST_CASE("Typed catch with no match still runs finally block") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

CHECK_THROWS_AS(chai.eval(R"(
var finally_ran = false
try {
throw(42)
}
catch(string e) {
// wrong type
}
finally {
finally_ran = true
}
)"), chaiscript::Boxed_Value);

CHECK(chai.eval<bool>("finally_ran") == true);
}

TEST_CASE("Multiple C++ exception types from registered functions") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

chai.add(chaiscript::fun([](int which) -> int {
switch (which) {
case 0: throw std::runtime_error("runtime");
case 1: throw std::out_of_range("range");
case 2: throw std::logic_error("logic");
default: return which;
}
}), "cpp_multi_throw");

CHECK(chai.eval<int>(R"(
var catch_count = 0
for (var i = 0; i < 3; ++i) {
try {
cpp_multi_throw(i)
}
catch(e) {
catch_count = catch_count + 1
}
}
catch_count
)") == 3);

CHECK(chai.eval<int>("cpp_multi_throw(5)") == 5);
}

TEST_CASE("Exception from C++ binary operator is catchable in ChaiScript") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

struct ThrowingType {
int value;
};

chai.add(chaiscript::user_type<ThrowingType>(), "ThrowingType");
chai.add(chaiscript::constructor<ThrowingType(int)>(), "ThrowingType");
chai.add(chaiscript::fun([](const ThrowingType &, const ThrowingType &) -> ThrowingType {
throw std::runtime_error("cpp operator+ threw");
}), "+");

CHECK(chai.eval<bool>(R"(
var caught = false
try {
var a = ThrowingType(1)
var b = ThrowingType(2)
var c = a + b
}
catch(e) {
caught = true
}
caught
)") == true);
}

TEST_CASE("Exception from C++ [] operator is catchable in ChaiScript") {
chaiscript::ChaiScript_Basic chai(create_chaiscript_stdlib(), create_chaiscript_parser());

struct IndexableType {
int value;
};

chai.add(chaiscript::user_type<IndexableType>(), "IndexableType");
chai.add(chaiscript::constructor<IndexableType(int)>(), "IndexableType");
chai.add(chaiscript::fun([](const IndexableType &, int idx) -> int {
if (idx < 0) { throw std::out_of_range("negative index"); }
return idx;
}), "[]");

CHECK(chai.eval<int>("var obj = IndexableType(0); obj[5]") == 5);

CHECK(chai.eval<bool>(R"(
var caught = false
try {
var x = obj[-1]
}
catch(e) {
caught = true
}
caught
)") == true);
}
Loading
Loading