Fix #635: [Bug] Segmentation Fault in chaiscript::Boxed_Number::get_as via async result interpolation#652
Closed
leftibot wants to merge 1 commit into
Conversation
…ck-local variable The optimized for-loop in chaiscript_optimizer.hpp stored the loop counter as a stack-local int and exposed it to ChaiScript via var(&i), creating a reference. When the := operator was used inside the loop body (e.g. ret := i), it copied the raw pointers to this stack variable into the target's Data. When the function returned via exception unwinding, the stack frame was destroyed, leaving dangling pointers in the return value. Accessing these pointers in the caller (e.g. via string interpolation) caused a segfault. The fix heap-allocates the loop counter via std::make_shared<int>, so the data survives scope exit through reference counting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
closing in favor of #655 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by @leftibot.
What changed
Files
Closes #635
Triggered by @lefticus.