Skip to content

Improve core shader warning usability - #3903

Open
poma12390 wants to merge 2 commits into
CaffeineMC:devfrom
poma12390:issue-2191-core-shader-warning
Open

poma12390 wants to merge 2 commits into
CaffeineMC:devfrom
poma12390:issue-2191-core-shader-warning

Conversation

@poma12390

@poma12390 poma12390 commented Sep 3, 2026 •

Copy link
Copy Markdown

Linked Issues

Closes #2191.

Proposed Changes

This change keeps core-shader compatibility problems actionable without covering normal gameplay with transient warnings:

  • Keep the current resource-pack compatibility problems in memory so they remain available after resource loading finishes.
  • Add a persistent compatibility-issues indicator to the main menu and pause screen.
  • Add a dedicated details screen that names each affected pack, explains the severity and likely impact, lists the detected shader files, and points the player to either Resource Packs or the compatibility documentation.
  • Distinguish server-provided packs from local packs so the suggested resolution and available actions match what the player can actually change.
  • Stop displaying the core-shader console toast over arbitrary screens. The compatibility report is still written when the detected problem set changes.
  • Run the scan after the resource reload future completes so the UI cannot retain stale pack names from the previous resource set.
  • Keep the empty state concise and position the pause-screen indicator away from the vanilla top-right controls.

The indicator provides a durable place to review the problem from an actionable screen, while resource reloads and ordinary gameplay remain unobstructed.

Validation

  • Ran ./gradlew build with OpenJDK 25.0.2: all 35 tasks completed successfully for the common, Fabric, FRAPI, and NeoForge projects.
  • Ran the Fabric development client with an enabled test resource pack containing assets/minecraft/shaders/core/rendertype_solid.vsh.
  • Confirmed the scanner identifies the pack and writes the affected shader path to the compatibility report.
  • Confirmed the working tree passes git diff --check.

The project currently has no automated test sources covering the resource-pack scanner or screen flow, so this change relies on the full multi-loader build and manual development-client validation.

@douira

douira commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Please confirm that you have read our contributing guidelines, in particular the parts about code style and AI-generated code.

@poma12390

Copy link
Copy Markdown
Author

Please confirm that you have read our contributing guidelines, in particular the parts about code style and AI-generated code.

Yes, I have read and understand the contributing guidelines

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve core shaders warning usability

2 participants