Skip to content

Static code analysis#21

Merged
BruceEckel merged 3 commits into
BruceEckel:masterfrom
bmuschko:static-code-analysis
Nov 6, 2016
Merged

Static code analysis#21
BruceEckel merged 3 commits into
BruceEckel:masterfrom
bmuschko:static-code-analysis

Conversation

@bmuschko
Copy link
Copy Markdown
Contributor

@bmuschko bmuschko commented Nov 6, 2016

I introduced a new aggregation task checkstyle and findbugs to execute the corresponding tools. Seems like there's some compilation issue with :exceptions:compileJmhJava. Seems like a real issue with the code.

I corrected the documentation to use the proper task for compiling code. The task build does far more than just compilation. The task classes is the correct one to use. Given that a user would never execute build there's also no need to detach the Checkstyle and FindBugs tasks from the check task (which is a task dependency of build).

@BruceEckel BruceEckel merged commit eeffb0d into BruceEckel:master Nov 6, 2016
@BruceEckel
Copy link
Copy Markdown
Owner

"Seems like there's some compilation issue with :exceptions:compileJmhJava."

The build for classes/compileJava -- using the Tags class -- knows to skip files marked with

// {CompileTimeError}

The problem here is that the compileJmhJava task is not, apparently, using the same approach and so is trying to compile TryAnything.java (and it would presumably try to compile the rest). What's not clear to me is how to make the "Tagged" build approach the universal one, so that compileJmhJava will also use it. Another approach might be to make compileJmhJava only work on the specific jmh subdirectories, although I can't tell if that would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants