Skip to content

Fix app crash if MAC address is empty, return empty string #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BornToBeRoot merged 1 commit into from
Feb 13, 2021
Merged

Fix app crash if MAC address is empty, return empty string #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Source/NETworkManager.Converters/PhysicalAddressToStringConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ public sealed class PhysicalAddressToStringConverter : IValueConverter
{
public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
{
return value == null ? string.Empty : MACAddressHelper.GetDefaultFormat((PhysicalAddress)value);
if (!(value is PhysicalAddress physicalAddress))
return string.Empty;

string macAddress = physicalAddress.ToString();

return string.IsNullOrEmpty(macAddress) ? string.Empty : MACAddressHelper.GetDefaultFormat(macAddress);
}

public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
Expand Down