Skip to content

Feature: Use Edge instead of iexplore for custom command #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Mar 6, 2023
Merged

Feature: Use Edge instead of iexplore for custom command #2006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb56f8
Feature: Use Edge instead of iexplore for custom command
BornToBeRoot Mar 6, 2023
e626084
Docs: Add #2006
BornToBeRoot Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/NETworkManager.Models/Network/IPScannerCustomCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public static List<CustomCommandInfo> GetDefaultList()
{
return new List<CustomCommandInfo>
{
new CustomCommandInfo(Guid.NewGuid(), "Internet Explorer", "iexplore.exe", @"http://$$ipaddress$$/"),
new CustomCommandInfo(Guid.NewGuid(), "Internet Explorer (https)", "iexplore.exe", @"https://$$ipaddress$$/"),
new CustomCommandInfo(Guid.NewGuid(), "Edge", "cmd.exe", @"/c start microsoft-edge:http://$$ipaddress$$/"),
new CustomCommandInfo(Guid.NewGuid(), "Edge (https)", "cmd.exe", @"/c start microsoft-edge:https://$$ipaddress$$/"),
new CustomCommandInfo(Guid.NewGuid(), "Windows Explorer (c$)", "explorer.exe", @"\\$$ipaddress$$\c$")
};
}
Expand Down
12 changes: 12 additions & 0 deletions Source/NETworkManager.Settings/SettingsManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,18 @@ private static void UpgradeToLatest(Version version)
Current.PortScanner_PortThreads = 1024;
}

// Add IP Scanner custom commands
foreach(var customCommand in IPScannerCustomCommand.GetDefaultList())
{
var customCommandFound = Current.IPScanner_CustomCommands.FirstOrDefault(x => x.Name == customCommand.Name);

if(customCommandFound == null)
{
_log.Info($"Add \"{customCommand.Name}\" to \"IPScanner_CustomCommands\"...");
Current.IPScanner_CustomCommands.Add(customCommand);
}
}

// Add or update Port Scanner port profiles
foreach (var portProfile in PortProfile.GetDefaultList())
{
Expand Down
1 change: 1 addition & 0 deletions docs/Changelog/next-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ The profiles and settings are automatically migrated to the new location when th
- Event handling when a host is found, user has canceled, etc. [#1969](https://github.com/BornToBeRoot/NETworkManager/pull/1969){:target="\_blank"}
- Remove option to set the preferred IP protocol for DNS resolution (can now be set globally) [#1950](https://github.com/BornToBeRoot/NETworkManager/pull/1950){:target="\_blank"}
- Create profile from IP scanner now passes the MAC address, if available [#1998](https://github.com/BornToBeRoot/NETworkManager/pull/1998){:target="\_blank"}
- Edge added to custom commands (iexplore deprecated in new installations) [#2006](https://github.com/BornToBeRoot/NETworkManager/pull/2006){:target="\_blank"}
- **Port Scanner**
- Add new port profiles / improve existing ones [#1909](https://github.com/BornToBeRoot/NETworkManager/pull/1909){:target="\_blank"}
- New Port state "Timed out" if the timelimit is reached. [#1969](https://github.com/BornToBeRoot/NETworkManager/pull/1969){:target="\_blank"}
Expand Down
10 changes: 5 additions & 5 deletions docs/Documentation/01_Application/04_IPScanner.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,11 @@ Custom commands that can be executed with a right click on the selected result.

**Default:**

| Name | File path | Arguments |
| ------------------------- | -------------- | ------------------------ |
| Internet Explorer | `iexplore.exe` | `http://$$ipaddress$$/` |
| Internet Explorer (https) | `iexplore.exe` | `https://$$ipaddress$$/` |
| Windows Explorer (c$) | `explorer.exe` | `\\$$ipaddress$$\c$` |
| Name | File path | Arguments |
| --------------------- | -------------- | ------------------------------------------------ |
| Edge | `cmd.exe` | `/c start microsoft-edge:http://$$ipaddress$$/` |
| Edge (https) | `cmd.exe` | `/c start microsoft-edge:https://$$ipaddress$$/` |
| Windows Explorer (c$) | `explorer.exe` | `\\$$ipaddress$$\c$` |

In the arguments you can use the following placeholders:

Expand Down