Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Add delete hotkey - #2452

Merged
Rokt33r merged 8 commits into
BoostIO:masterfrom
jacobherrington:add-delete-hotkey
Nov 2, 2018
Merged

Rokt33r merged 8 commits into
BoostIO:masterfrom
jacobherrington:add-delete-hotkey

Conversation

@jacobherrington

Copy link
Copy Markdown
Contributor

Would love to get some testing on this one 👍

Solves #2446

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 5, 2018
Comment thread browser/main/lib/ConfigManager.js Outdated
toggleMain: OSX ? 'Command + Alt + L' : 'Super + Alt + E',
toggleMode: OSX ? 'Command + Option + M' : 'Ctrl + M'
toggleMode: OSX ? 'Command + Alt + M' : 'Ctrl + M',
deleteNote: OSX ? 'Command + Alt + Backspace' : 'Ctrl + Alt + Backspace'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hotkey is pure evil on Linux. It close all applications and go back to the login screen. Can you change it to Ctrl + Shift + Backspace

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahahaha yes

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 13, 2018
@Rokt33r Rokt33r added next release (v0.11.11) awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed approved 👍 Pull request has been approved by sufficient reviewers. next release (v0.11.11) labels Oct 23, 2018

@Rokt33r Rokt33r left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobherrington Could you fix the conflicts?

@jacobherrington

Copy link
Copy Markdown
Contributor Author

@Rokt33r Fixed, pretty sure that's right :)

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Oct 27, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Nov 2, 2018
@Rokt33r
Rokt33r merged commit b03ad0c into BoostIO:master Nov 2, 2018
yougotwill added a commit to yougotwill/Boostnote that referenced this pull request Dec 2, 2018
@yougotwill yougotwill mentioned this pull request Dec 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants