Skip to content

Fixed Uri encoding in rss feed (important for urls containing international letters) #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rxtur merged 2 commits into from
May 11, 2016
Merged

Fixed Uri encoding in rss feed (important for urls containing international letters) #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ef0fc6
Fixed Uri encoding in rss feed
Vladekk May 9, 2016
5d13a23
Replaced occurrences of AbsoluteLink.ToString to AbsoluteLink.Absolut…
Vladekk May 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions BlogEngine/BlogEngine.Core/Services/Syndication/SyndicationGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ private static void WriteAtomEntry(XmlWriter writer, IPublishable publishable)
writer.WriteEndElement();

writer.WriteStartElement("link");
writer.WriteAttributeString("href", publishable.AbsoluteLink.ToString());
writer.WriteAttributeString("href", publishable.AbsoluteLink.AbsoluteUri);
writer.WriteEndElement();

writer.WriteStartElement("author");
Expand All @@ -498,7 +498,7 @@ private static void WriteAtomEntry(XmlWriter writer, IPublishable publishable)

writer.WriteStartElement("link");
writer.WriteAttributeString("rel", "related");
writer.WriteAttributeString("href", String.Concat(publishable.AbsoluteLink.ToString(), "#comment"));
writer.WriteAttributeString("href", String.Concat(publishable.AbsoluteLink.AbsoluteUri, "#comment"));
writer.WriteEndElement();

// ------------------------------------------------------------
Expand Down Expand Up @@ -604,7 +604,7 @@ private static void WriteAtomEntry(XmlWriter writer, IPublishable publishable)
"wfw",
"comment",
"http://wellformedweb.org/CommentAPI/",
String.Concat(publishable.AbsoluteLink.ToString(),
String.Concat(publishable.AbsoluteLink.AbsoluteUri,
"#comment"));
writer.WriteElementString(
"wfw",
Expand Down Expand Up @@ -673,7 +673,7 @@ private static void WriteRssItem(XmlWriter writer, IPublishable publishable)
}

writer.WriteElementString("description", content);
writer.WriteElementString("link", publishable.AbsoluteLink.ToString());
writer.WriteElementString("link", publishable.AbsoluteLink.AbsoluteUri);

// ------------------------------------------------------------
// Write enclosure tag for podcasting support
Expand All @@ -697,7 +697,7 @@ private static void WriteRssItem(XmlWriter writer, IPublishable publishable)
if (post != null)
{
writer.WriteElementString(
"comments", String.Concat(publishable.AbsoluteLink.ToString(),
"comments", String.Concat(publishable.AbsoluteLink.AbsoluteUri,
"#comment"));
}

Expand Down Expand Up @@ -791,7 +791,7 @@ private static void WriteRssItem(XmlWriter writer, IPublishable publishable)
"wfw",
"comment",
"http://wellformedweb.org/CommentAPI/",
String.Concat(publishable.AbsoluteLink.ToString(),
String.Concat(publishable.AbsoluteLink.AbsoluteUri,
"#comment"));
writer.WriteElementString(
"wfw",
Expand Down
4 changes: 2 additions & 2 deletions BlogEngine/BlogEngine.Core/Web/HttpHandlers/SiteMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void ProcessRequest(HttpContext context)
foreach (var post in Post.Posts.Where(post => post.IsVisibleToPublic))
{
writer.WriteStartElement("url");
writer.WriteElementString("loc", post.AbsoluteLink.ToString());
writer.WriteElementString("loc", post.AbsoluteLink.AbsoluteUri.ToString());
writer.WriteElementString(
"lastmod", post.DateModified.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
writer.WriteElementString("changefreq", "monthly");
Expand All @@ -63,7 +63,7 @@ public void ProcessRequest(HttpContext context)
foreach (var page in Page.Pages.Where(page => page.IsVisibleToPublic))
{
writer.WriteStartElement("url");
writer.WriteElementString("loc", page.AbsoluteLink.ToString());
writer.WriteElementString("loc", page.AbsoluteLink.AbsoluteUri);
writer.WriteElementString(
"lastmod", page.DateModified.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
writer.WriteElementString("changefreq", "monthly");
Expand Down
2 changes: 1 addition & 1 deletion BlogEngine/BlogEngine.Core/Web/HttpHandlers/TrackbackHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public void ProcessRequest(HttpContext context)
postId.Length == 36)
{
post = Post.GetPost(new Guid(postId));
this.ExamineSourcePage(url, post.AbsoluteLink.ToString());
this.ExamineSourcePage(url, post.AbsoluteLink.AbsoluteUri);
var containsHtml = !string.IsNullOrEmpty(excerpt) &&
(RegexHtml.IsMatch(excerpt) || RegexHtml.IsMatch(title) ||
RegexHtml.IsMatch(blogName));
Expand Down