feat(sdk-coin-ada): add MPCv2 support to recoverConsolidations - #9497

WCI-1232

AI-generated review — auto-generated by Claude Code (wallet-platform:review-pr). Please use your own judgment before acting on any findings.

Phase 1 — Summary

Adds optional precomputedMaterial?: EddsaSigningMaterial to Ada.recover(), enabling MPCv2 vs MPCv1 dispatch based on signingMaterial.version. Ada.recoverConsolidations() now detects signing material once before the scan loop and threads it into each recover() call via precomputedMaterial, eliminating repeated keycard decryption across up to 20+ index iterations. Reuses getEddsaSigningMaterial / signEddsaMpcV2RecoveryTx / decryptKeychainPrivateKey helpers from sdk-core, matching the DOT (WCI-1236) and SOL (WCI-496) pattern.

Files changed: 2 — modules/sdk-coin-ada/src/ada.ts, modules/sdk-coin-ada/test/unit/ada.ts | +329 / -35 lines

flowchart TD
    A["recover(params, precomputedMaterial?)"] --> B{precomputedMaterial\nprovided?}
    B -- yes --> C[skip getEddsaSigningMaterial]
    B -- no --> D["getEddsaSigningMaterial(userKey, passphrase)"]
    C --> E{signingMaterial.version}
    D --> E
    E -- v2 --> F["signAdaMpcV2Recovery → signEddsaMpcV2RecoveryTx"]
    E -- v1 --> G["decryptKeychainPrivateKey → EDDSAMethods.getTSSSignature"]
    F --> H[txBuilder.addSignature]
    G --> H

    RC["recoverConsolidations()"] --> RP{walletPassphrase\nset?}
    RP -- yes --> RA["assert(params.userKey)\ngetEddsaSigningMaterial ONCE"]
    RP -- no --> RB[signingMaterial = undefined]
    RA --> RL["for i in startIdx..endIdx"]
    RB --> RL
    RL --> RR["recover(recoverParams, signingMaterial)"]

Phase 2 — Ticket Alignment

Ticket: WCI-1232

PR title: feat(sdk-coin-ada): add MPCv2 support to recoverConsolidations

The implementation matches the ticket scope. The PR also delivers MPCv2 support to recover() itself (WCI-1222 dependency), which is a prerequisite and correctly called out in the PR body. No misalignment detected.

Phase 3 — Index Analysis

No new database queries introduced.

Phase 4 — Type Safety

No as any, @ts-ignore, or double casts in added lines.

Sinon spy cast uses the safe as unknown as { getEddsaSigningMaterial: unknown } pattern — correct.

One pre-existing (not introduced) any[] on consolidationTransactions is unchanged — not a regression.

Phase 5 — MPCv2 Correctness & Test Quality

Correctness

• ✅ getEddsaSigningMaterial called with whitespace-stripped userKey — recover() strips explicitly (params.userKey.replace(/\s/g, '')); recoverConsolidations() passes raw but the wrapper getEddsaSigningMaterial() calls sharedGetEddsaSigningMaterial(userKey.replace(/\s/g, ''), ...) internally.
• ❌ assert() guards in recover() for userKey/backupKey/walletPassphrase — recoverConsolidations has assert(params.userKey, 'missing userKey') before the loop, but inside recover() itself the added code does params.userKey.replace(/\s/g, '') without an assert guard. If params.userKey is undefined, the error thrown will be a generic TypeError: Cannot read properties of undefined (reading 'replace') rather than a clear message. The guard pattern used in recoverConsolidations should be mirrored in recover().
• ✅ Unsigned sweep path untouched — the else branch (no walletPassphrase) is unmodified.
• ✅ decryptKeychainPrivateKey used for MPCv1 backup key — correct helper from sdk-core.
• ✅ recoverConsolidations(): signing material detected ONCE before the loop, passed as precomputedMaterial to each recover() call.
• ✅ recover(): correctly short-circuits with precomputedMaterial ?? (await this.getEddsaSigningMaterial(...)).

Test Quality

• ✅ v2 path: asserts getTSSSignature NOT called (sandBox.assert.notCalled(getTSSSignatureSpy)).
• ✅ v1 path: asserts getTSSSignature WAS called (sandBox.assert.calledOnce(getTSSSignatureSpy)).
• ❌ No crypto verification using nacl.sign.detached.verify — the MPCv2 recovery test validates res.hasOwnProperty('serializedTx') and parses the output address, but never verifies the Ed25519 signature cryptographically. The DOT canonical pattern includes nacl.sign.detached.verify to confirm the produced signature is actually valid.
• ✅ Mismatched bitgoKey vs commonKeyChain error test present — rejectedWith('EdDSA MPCv2 recovery: commonKeyChain from keycard does not match bitgoKey').
• ✅ Consolidations: getEddsaSigningMaterial asserted called exactly once across 2-funded-index scan.
• ❌ Guard tests incomplete — test for missing userKey in recoverConsolidations is present, but no test for the case where backupKey is missing in recover() directly, and no test for missing walletPassphrase guard behavior in recover().

Consistency vs DOT (#9484)

• ✅ Sinon stubs use as unknown as { method: unknown } (not as any) — correct.
• ✅ Describe block naming ('Recover Transactions (MPCv2):', 'Build Consolidation Recoveries (MPCv2):') is consistent with the DOT pattern style.

Summary of ❌ Findings

None of these are blockers, but items 1 and 2 are the most likely to cause confusion in future debugging.

Generated by [wallet-platform:review-pr] via Claude Code