feat(sdk-core): add root-fetch detour in getUserPrv for safe child wallets - #9488
Open
s84krish wants to merge 1 commit into
Open
Conversation
Contributor
s84krish
force-pushed
the
sibikrishnan/wcn-1200-sdk-multisig-signing-root-fetch-detour-in-getuserprvasync
branch
from
August 13, 2026 15:34
ebc1572 to
a8653a5
Compare
s84krish
marked this pull request as ready for review
August 13, 2026 16:18
s84krish
requested review from
davidkaplanbitgo,
pranavjain97 and
rishikeshdadam136
August 13, 2026 16:18
s84krish
force-pushed
the
sibikrishnan/wcn-1200-sdk-multisig-signing-root-fetch-detour-in-getuserprvasync
branch
from
August 13, 2026 17:57
a8653a5 to
fb3f9e8
Compare
davidkaplanbitgo
requested changes
Aug 14, 2026
|
|
||
| const decryptedPrv = await this.wallet.getPrv({ walletPassphrase }); | ||
| let decryptedPrv: string; | ||
| if (this.wallet.safeId()) { |
Contributor
There was a problem hiding this comment.
Even if the wallet does come from a safe - if the spender is someone who the wallet was shared with, they will not require this detour - it is only required if it is the wallet minter.
s84krish
force-pushed
the
sibikrishnan/wcn-1200-sdk-multisig-signing-root-fetch-detour-in-getuserprvasync
branch
from
August 14, 2026 15:11
fb3f9e8 to
2a91432
Compare
s84krish
force-pushed
the
sibikrishnan/wcn-1200-sdk-multisig-signing-root-fetch-detour-in-getuserprvasync
branch
from
August 14, 2026 16:24
2a91432 to
8850785
Compare
pranavjain97
approved these changes
Aug 14, 2026
| ); | ||
| } | ||
|
|
||
| const rootKeychain = params.rootKeychain ?? (await fetchRootKeychainForSafeChild(keychains, childKeychain)); |
Contributor
There was a problem hiding this comment.
nit: doesn't assert rootKeychain.id === childKeychain.parent before use, the pub-match check below catches a mismatch but an explicit assertion would make the invariant self-documenting
|
|
||
| // Soft seed derivation for SMC (and any explicit coldDerivationSeed), including | ||
| // after decrypting encryptedPrv when no params.prv was passed. | ||
| if (userPrv && params.coldDerivationSeed) { |
Contributor
There was a problem hiding this comment.
nit: coldDerivationSeed now applies after decrypting encryptedPrv too, previously only for direct params.prv. no call site currently passes both together, intentional new path or unused scope creep?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WCN-1200
Summary
Test plan