Skip to content

feat(sdk-coin-dot): add MPCv2 support to recoverConsolidations #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ralph-bitgo wants to merge 1 commit into
base: wci-1227-dot-mpcv2-recovery
Choose a base branch
from
+204 −85
Open

feat(sdk-coin-dot): add MPCv2 support to recoverConsolidations #9486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions modules/sdk-coin-dot/src/dot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export class Dot extends BaseCoin {
* @returns {MPCTx} the serialized transaction hex string and index
* of the address being swept
*/
async recover(params: MPCRecoveryOptions): Promise<MPCTx | MPCSweepTxs> {
async recover(params: MPCRecoveryOptions, precomputedMaterial?: EddsaSigningMaterial): Promise<MPCTx | MPCSweepTxs> {
if (!params.bitgoKey) {
throw new Error('missing bitgoKey');
}
Expand Down Expand Up @@ -402,7 +402,8 @@ export class Dot extends BaseCoin {
assert(params.backupKey, 'missing backupKey');
assert(params.walletPassphrase, 'missing wallet passphrase');

const signingMaterial = await this.getEddsaSigningMaterial(params.userKey, params.walletPassphrase);
const signingMaterial =
precomputedMaterial ?? (await this.getEddsaSigningMaterial(params.userKey, params.walletPassphrase));
await this.addRecoverySignature(
signingMaterial,
params.backupKey.replace(/\s/g, ''),
Expand Down Expand Up @@ -485,10 +486,16 @@ export class Dot extends BaseCoin {
const accountId = MPC.deriveUnhardened(bitgoKey, basePath).slice(0, 64);
const baseAddress = this.getAddressFromPublicKey(accountId);

// Detect signing material once to avoid re-decrypting the keycard on every loop iteration.
const signingMaterial =
params.walletPassphrase && params.userKey
? await this.getEddsaSigningMaterial(params.userKey.replace(/\s/g, ''), params.walletPassphrase)
: undefined;

const consolidationTransactions: any[] = [];
let lastScanIndex = startIdx;
for (let i = startIdx; i < endIdx; i++) {
const recoverParams = {
const recoverParams: MPCRecoveryOptions = {
userKey: params.userKey,
backupKey: params.backupKey,
bitgoKey: params.bitgoKey,
Expand All @@ -500,7 +507,7 @@ export class Dot extends BaseCoin {

let recoveryTransaction;
try {
recoveryTransaction = await this.recover(recoverParams);
recoveryTransaction = await this.recover(recoverParams, signingMaterial);
} catch (e) {
if (e.message === 'Did not find address with funds to recover') {
lastScanIndex = i;
Expand Down
Loading