fix(sdk-coin-starknet): normalize signableHex and widen verifyTransaction guard#9072
Open
shubham-damkondwar wants to merge 1 commit into
Open
fix(sdk-coin-starknet): normalize signableHex and widen verifyTransaction guard#9072shubham-damkondwar wants to merge 1 commit into
shubham-damkondwar wants to merge 1 commit into
Conversation
…tion guard Node's hex decoder under Node 24+ rejects '0x' prefixes in Buffer.from, producing empty buffers. This caused the Starknet deploy account signing path to send empty hashes to the keyserver, resulting in 400 validation errors. - Stripped '0x' prefix and left-padded signableHex to 64 characters to conform with standard BitGo raw hex convention. - Widened verifyTransaction short-circuit to support raw 64-character hex hashes, preventing runtime JSON parsing crashes. - Updated builder unit tests and added verification test case. TICKET: CECHO-1376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's hex decoder under Node 24+ rejects '0x' prefixes in Buffer.from, producing empty buffers. This caused the Starknet deploy account signing path to send empty hashes to the keyserver, resulting in 400 validation errors.
TICKET: CECHO-1376