fix(abstract-eth): fix verifyTransaction for base multig address duri…#8938
Merged
Conversation
df3de68 to
3f5aab5
Compare
…ng enable token flow TICKET: CHALO-530
3f5aab5 to
a82b334
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: CHALO-530
This pull request adds support for ERC-7984 token enablement transactions on multisig base-address wallets, specifically handling cases where the transaction recipient is the Zama ACL contract instead of the wallet's base address. It also introduces new tests to verify this behavior.
ERC-7984 Token Enablement Support:
AbstractEthLikeNewCoinsso that, forenabletokentransactions, if the transaction is targeting the Zama ACL contract (as configured for the network), the usual recipient address equality check is bypassed. This ensures that valid enabletoken transactions to the ACL contract are accepted.Testing Enhancements:
eth.tsto verify thatverifyTransactioncorrectly allows enabletoken transactions where thetxParamsrecipient is the wallet base address and thetxPrebuildrecipient is the Zama ACL contract, and that it rejects cases where the recipient is not the ACL contract.