Skip to content

fix(statics): replace bn.js by BigInt native implementation - #2286

Merged
mmcshinsky-bitgo merged 1 commit into
masterfrom
STLX-16485_add_bn_to_statics
May 17, 2022
Merged

fix(statics): replace bn.js by BigInt native implementation#2286
mmcshinsky-bitgo merged 1 commit into
masterfrom
STLX-16485_add_bn_to_statics

Conversation

@emiacc

@emiacc emiacc commented May 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Replace bn.js by BigInt native implementation

STLX-16485

@emiacc
emiacc force-pushed the STLX-16485_add_bn_to_statics branch from a655e6a to db5920b Compare May 17, 2022 15:27
Emiliano Scavuzzo
fix(statics): remove bn.js dependency
d473aa1 
replace bn.js with BigInt since statics is dependecy-free

STLX-16485
@emiacc
emiacc force-pushed the STLX-16485_add_bn_to_statics branch from db5920b to d473aa1 Compare May 17, 2022 15:56
@codecov

codecov Bot commented May 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2286 (59c3428) into master (f56246c) will increase coverage by 85.70%.
The diff coverage is 100.00%.

❗ Current head 59c3428 differs from pull request most recent head d473aa1. Consider uploading reports for the commit d473aa1 to get more accurate results

@@             Coverage Diff             @@
##           master    #2286       +/-   ##
===========================================
+ Coverage        0   85.70%   +85.70%     
===========================================
  Files           0      186      +186     
  Lines           0     9212     +9212     
  Branches        0     1390     +1390     
===========================================
+ Hits            0     7895     +7895     
- Misses          0      901      +901     
- Partials        0      416      +416
Flag Coverage Δ
unit 85.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/statics/src/networks.ts 100.00% <100.00%> (ø)
modules/account-lib/src/utils/index.ts 45.45% <0.00%> (ø)
modules/account-lib/src/mpc/tss.ts 96.49% <0.00%> (ø)
modules/account-lib/src/coin/stx/index.ts 100.00% <0.00%> (ø)
...dules/account-lib/src/coin/hbar/transferBuilder.ts 97.61% <0.00%> (ø)
modules/account-lib/src/coin/sol/transaction.ts 95.07% <0.00%> (ø)
modules/account-lib/src/coin/xtz/utils.ts 96.26% <0.00%> (ø)
modules/account-lib/src/coin/eth/utils.ts 81.57% <0.00%> (ø)
modules/account-lib/src/coin/near/utils.ts 83.33% <0.00%> (ø)
...les/account-lib/src/coin/trx/transactionBuilder.ts 80.00% <0.00%> (ø)
... and 177 more

@emiacc
emiacc marked this pull request as ready for review May 17, 2022 16:08
@emiacc
emiacc requested a review from a team May 17, 2022 16:08
@emiacc emiacc changed the title fix(statics): add bn.js as a dependency fix(statics): replace bn.js by BigInt native implementation May 17, 2022
@sunnybak
sunnybak self-requested a review May 17, 2022 18:00
sunnybak
sunnybak approved these changes May 17, 2022
View reviewed changes

@sunnybak sunnybak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmcshinsky-bitgo
mmcshinsky-bitgo merged commit 813ff36 into master May 17, 2022
@bitgo-ai-agent-dev bitgo-ai-agent-dev Bot mentioned this pull request Aug 11, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmcshinsky-bitgo mmcshinsky-bitgo mmcshinsky-bitgo approved these changes
+1 more reviewer
@sunnybak sunnybak sunnybak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emiacc @sunnybak @mmcshinsky-bitgo