fixes loader IDA-7 compatibility#39
Merged
Merged
Conversation
ivg
requested changes
Feb 15, 2019
Member
ivg
left a comment
There was a problem hiding this comment.
Please, don't import *, it will pollute namespace and make it very fragile to the new changes (if it didn't break the code already), do a guarded import, e.g.,
try:
from idaapi import get_segm_name as idat_segm_name
except ImportError:
from idc import get_segm_name as ida_segm_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in loader script due to compatibility with IDA-7 version.
The core of the problem is in
get_segm_namefunction, which exists both in6.9and7.1versions, but was shadowed with some other implementation in the latter one.