Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
187 changes: 173 additions & 14 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I see you installed the Axios and i18next packages. I'm familiar with Axios and will have to do a search on i18next to understand briefly. I know it is related to translating 😅 and I see there is a react version of it also.

Copy link
Copy Markdown
Contributor Author

@negar-75 negar-75 Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah in one of my previous projects I used i18next for translation, I think this is a good library for this, I do not know any better one 😂😂

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are other libraries like react-intl and react-polyglot. Your addition and utilizing the i18next library for React works great, and we can continually add to the languages we upload and adjust in the future, but for now, this library makes absolute sense how you integrated it.

Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/react": "^12.1.4",
"@testing-library/user-event": "^13.5.0",
"axios": "^1.5.0",
"i18next": "^23.4.6",
"iconsax-react": "^0.0.8",
"prop-types": "^15.8.1",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"react-i18next": "^13.2.2",
"react-masonry-css": "^1.0.16",
"react-scripts": "5.0.0",
"react-simple-typewriter": "^5.0.1",
Expand Down
Loading