Skip to content

Update README.md for Hindi Translation#65

Merged
XanderRubio merged 3 commits intoBeforeIDieCode:mainfrom
vrun1208:add-readme-in-hindi-translation
Sep 7, 2023
Merged

Update README.md for Hindi Translation#65
XanderRubio merged 3 commits intoBeforeIDieCode:mainfrom
vrun1208:add-readme-in-hindi-translation

Conversation

@vrun1208
Copy link
Copy Markdown
Contributor

@vrun1208 vrun1208 commented Sep 6, 2023

Hindi Translation ADDED for Documentation #30

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 5:01am

@vrun1208
Copy link
Copy Markdown
Contributor Author

vrun1208 commented Sep 6, 2023

Hi @XanderRubio, this is my first contribution on this repo, as i was reading the contribution guidelines I found out that I missed the couple of steps like updating contributors.md . Is it okay? or do I have to complete that first before opening pr

@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Sep 7, 2023 •
edited
Loading

Hi @vrun1208

Thank you for taking the time to add the translations! All good as when I merge this we can update the issue #30 of the work you have done and that it still needs the other docs translated. I encourage you to also fill out your text and image for what you want to do before you die also by following the CONTRIBUTION-GUIDELINES.md. I will review your file change later today and then will be merging 🙏🏻. Have a great day!

Xander

XanderRubio
XanderRubio approved these changes Sep 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@XanderRubio XanderRubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vrun1208!

It looks excellent and merging now! Congratulations Clapping Hands

@XanderRubio XanderRubio merged commit 3a6aa6f into BeforeIDieCode:main Sep 7, 2023
@XanderRubio XanderRubio mentioned this pull request Sep 7, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XanderRubio XanderRubio XanderRubio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vrun1208 @XanderRubio