Adding flags to every translated README files (#38)#44
Merged
XanderRubio merged 1 commit intoBeforeIDieCode:mainfrom Aug 30, 2023
luc881:issue-38-add-flags-to-README
Merged
Adding flags to every translated README files (#38)#44XanderRubio merged 1 commit intoBeforeIDieCode:mainfrom luc881:issue-38-add-flags-to-README
XanderRubio merged 1 commit intoBeforeIDieCode:mainfrom
luc881:issue-38-add-flags-to-README
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
XanderRubio
approved these changes
Aug 30, 2023
Member
XanderRubio
left a comment
There was a problem hiding this comment.
Hi @luc881,
Thank you for your time in adding the flags to each translated README file, and I like how you added the two flags for Arabic addtionally. Looks great, and please let me know your further thoughts and suggestions on enhancing this project. The next step is to get the files translated and later on add more and more languages. This will now close issue #38. Great work Luciano!
Member
|
Thank you for looking @AbdullahWins 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking forward to your feedback and suggestions. Thank you!
Fixes #38