Skip to content

Add Tyler Celestin #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XanderRubio merged 4 commits into from
Aug 29, 2023
Merged

Add Tyler Celestin #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9df6ef
work on bid
ccelest1 Aug 29, 2023
4e0ccc3
Add Craig Celestin to Before I Die
ccelest1 Aug 29, 2023
9e4ed50
changes to name
ccelest1 Aug 29, 2023
bcc8b2e
Merge branch 'main' into add-Tyler-Celestin
XanderRubio Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
</a>
</td>
<!-- End of column-5 -->
<!-- Start of column -->
<!-- Start of column-6 -->
<td align="center">
<a href="https://github.com/luc881">
<img
Expand All @@ -160,6 +160,18 @@
<sub>Luciano Juarez</sub>
</a>
</td>
<!-- End of column -->
<!-- End of column-6 -->
<!-- Start of column-7 -->
<td align="center">
<a href="https://github.com/ccelest1">
<img
src="https://avatars.githubusercontent.com/u/79764816?v=4"
width="100px"
/>
<br />
<sub>Tyler Celestin</sub>
</a>
</td>
<!-- End of column-7 -->
</tr>
</table>
Binary file added public/img/avatar/Tyler_Celestin.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/img/bid_image/Tyler_Celestin.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/img/dummy_image/10.jpg
View file
Open in desktop
Copy link
Copy Markdown
Member

@XanderRubio XanderRubio Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Brooklyn Bridge photo, and I haven't thought of this before, we can create an open issue to add more dummy images to the home page. These will be displayed beind the "An Open Source Project" Text, and the Before I Die Code logo.

Screenshot 2023-08-29 at 20 16 46

Copy link
Copy Markdown
Contributor Author

@ccelest1 ccelest1 Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I have a couple suggestions to add on

  • dummy images weren't elucidated or even mentioned in the contribution-guidelines, but when i took a look at the code i deciphered it was the images above. The profile photo and the photo of what we want to achieve makes sense, but I wanted to really understand what i should put for the dummy and i decided to put where I am from and fit the aesthetic that I thought was so nice and calming.

  • I think you can be more clear about what people should post in terms of what they want to do before they die. A few of them I thought were incredibly meaningful, but there some of them I thought were out of place and jarring.

    • Like you said in the contributing.md, it should be something significant and extrinsic separate from just the journey of software itself

  • I saw this in the contributing.md and was wondering where this was and if needs to be changed Replace "YOUR_CITY_COUNTRY_AND_FLAG" with your city, country, and flag White Flag Chequered FlagBlack Flagemoji. I saw that instead of the emoji, it was the country abbreviated.

  • Additionally, while the design is good for the current number of contributors (1) the images will get distorted and it may do some good to have a slideshow for the dummy images as opposed to them being static so they are crowded together, (2) the same should apply for the bottom as well

    • The design currently is fine, but I'm wondering if theres a way that it can be updated/modernized without sacrificing its artistic integrity.

  • I also found the rainbow background of text, very distracting. It would be nice if either people can decide what color they can have for the background of text or if it can be changed to a more neutral but pleasing color.

  • I also noticed that certain times, the photo dimension would result in info about users being cut off if perhaps your window was minimized or on different screens.

  • I'm just wondering if this gets bigger, how you will handle content moderation.

Also I checked out the about.md and that it was incredibly inspiring, I wish that was presented in a more immediate way or presented to the user so they get the grasp of the project better.

Copy link
Copy Markdown
Member

@XanderRubio XanderRubio Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valuable feedback! I would like to create open issues for all of your points! Yes, I am in agreement with the dummy images being on rotation, and I found it interesting when reviewing your merge request that you added a dummy image without the mention of a dummy image in the contribution guideline. I'm grateful you did this as I was early on thinking about the rotation of the images to add more variety when users view the page of images. Additionally, adding into the documentation clearer about what should be posted in terms of meaning. I'm now thinking how we could add a backed component to fetch a simple API call from Unsplash or go the route of contribution sourcing of high-level images to represent meaningful before I Die images to store locally in the code or an added database to display.

1️⃣ I will add all your suggestions and feedback to the ROADMAP to organize and then create open issues👍🏻 and make a checklist. If you have time and would like to help in creating open issues from the checklist that would be great😇

2️⃣From a design perspective, what layout do you find most appealing for a modern, professional home that is sleek and highlights high-quality images in various art styles on rotation?

Screenshot 2023-08-30 at 02 18 25

3️⃣ I was wondering if it makes sense for the layout of images to be behind the text on the home screen sections, with a transparent tint or a 3 x 3 grid, and adjust the text layout accordingly. Do you have any thoughts on this?

4️⃣ To expand this project, we will need to build a community. That's why I've set up this repository as an organization so that we can have members and utilize GitHub's features for community organization, moderation, and engagement.

5️⃣ And also perhaps a clearer section in the README or even in the website itself to share the about.md

🙏🏻 I would like to make the project big as the question of What I Want to Do Before I Die has played a big part in my life, and it is a project that I am passionate about as a medium to help other developers and learn in the process.

Thank you, Tyler!

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/Components/BrickLayout/BrickLayout.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ const BrickLayout = () => {
<img src="img/dummy_image/8.jpg" alt="" />
<img src="img/dummy_image/9.jpg" alt="" />
</div>
<div className={styles["brick-column"]}>
<img src="img/dummy_image/10.jpg" alt="" />
</div>
</div>
</div>
)
Expand Down
14 changes: 11 additions & 3 deletions src/Jsons/Contributors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[
{
{
"id": "Alexander Clemens",
"image": "img/bid_image/Alexander_Clemens.jpg",
"avatar": "img/avatar/Alexander_Clemens.jpg",
Expand Down Expand Up @@ -151,5 +150,14 @@
"location": "Puebla, Mexico 🇲🇽",
"GitHub": "https://github.com/luc881",
"text": "I want to visit as many countries as possible before I die."
}
},
{
"id":"Tyler Celestin",
"image":"img/bid_image/Tyler_Celestin.jpg",
"avatar":"img/avatar/Tyler_Celestin.jpg",
"name":"Tyler Celestin",
"location":"Brooklyn, New York, USA",
"GitHub":"https://github.com/ccelest1",
"text":"I sincerely appreciate great design and aesthetics. In that same vein, I would cherish the opportunity to travel to vistas that exhibit careful and detailed architecture that is synergistic with their cultural and environmental surroundings. One of those places is, of course, Japan, which is renowned for its talented engineers and attention to green practices. One of my dreams is to work in the field of design, or potentially civil engineering if possible."
}
]