Add translation section to README with flag emojis (#38)#41
Add translation section to README with flag emojis (#38)#41XanderRubio merged 1 commit intoBeforeIDieCode:mainfrom luc881:issue-38-add-translation-section
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hola Luciano! Thank you for taking the time to add the flags. I'll be reviewing now and making the merge shortly. I was traveling the past several days and back to my home base and will be quick to respond. I like your updated GitHub profile README file with the computer screen gif and Backend Developer title! |
XanderRubio
left a comment
There was a problem hiding this comment.
Hi @luc881, great job! I really appreciate the addition of the circle flags to the README and the translations page. Thank you for taking the time to do that. We will continue to work on this project day by day and week by week. I was wondering if you could give me your opinion on whether it makes sense to display all the flags on each translated README file. For example, if the main README file is in English, a flag representing the language would be displayed, so that when someone views the Spanish version of the README, they can easily click on the English flag to view the translation. This is a minor detail, but it came to mind and I wanted to get your thoughts. The same would apply to the Translations.md file, where we would add a flag to represent the English language that has been translated. Thank you again and have a great day, Luciano!
|
Merging this pull request to close out issue #38 |
|
Hi @XanderRubio, thank you for your feedback. I believe it would be helpful to add the flags to all the README files. Should I include them in all the README files or just in the Spanish one?🤔 Have a nice day. |
|
This makes sense, and thank you, Luciano, for your feedback. I will go ahead and reopen this issue #38 and edit the instructions for record purposes to have all the flags to all the README files linked to appropriate README files for translation. In addition, I will assign this issue to you😉. Thank you Luciano and please let me know if you have more thoughts to add value. |
Details:
In this pull request, I've addressed issue #38 by adding a translation section to the README. To enhance the user experience, I've incorporated flag images to represent different language options. The flag images have been sourced from the "country-flags" and "circle-flags" repositories.
Resources Used:
Fixes #38