Skip to content

Contributor text fonts#40

Merged
XanderRubio merged 2 commits intoBeforeIDieCode:mainfrom
lefty93:contributor-text-fonts
Aug 29, 2023
Merged

Contributor text fonts#40
XanderRubio merged 2 commits intoBeforeIDieCode:mainfrom
lefty93:contributor-text-fonts

Conversation

@lefty93
Copy link
Copy Markdown
Contributor

@lefty93 lefty93 commented Aug 25, 2023

Two google fonts are added & !important removed from css-reset.
image

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 11:19pm

Copy link
Copy Markdown
Member

@XanderRubio XanderRubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, Chu! I really appreciate the improvements you made to the Before I Die project and UI. Your editing of the text that appears when clicking on a contributor's image, as well as the contributor's text statement, was excellent. I am grateful that you took the time to add the Google font of EB Garamond and Fira Code, and edited the appropriate CSS files, including the footer. I noticed that you also changed the mobile window size for the isMobile variable to 640 pixels or less, which makes more sense to me. Thank you very much, Chu! I am now merging your contributions into the project. This closes out issue #23 for enhancing the Contributor font.

@XanderRubio XanderRubio merged commit c8f8615 into BeforeIDieCode:main Aug 29, 2023
@lefty93 lefty93 deleted the contributor-text-fonts branch September 2, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🟢 Improve the font for Contributors text entered and title "Before I Die"

2 participants