Skip to content

Issue#26#33

Merged
XanderRubio merged 3 commits intoBeforeIDieCode:mainfrom
viktoriussuwandi:issue#26
Aug 24, 2023
Merged

Issue#26#33
XanderRubio merged 3 commits intoBeforeIDieCode:mainfrom
viktoriussuwandi:issue#26

Conversation

@viktoriussuwandi
Copy link
Copy Markdown
Contributor

@viktoriussuwandi viktoriussuwandi commented Aug 24, 2023

issue #26

Hi @XanderRubio,
I'm just trying to jump on this issue, please check it out

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 11:49am

@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Aug 24, 2023

Hi Viktorius! Thank you for your time into #26. I'm looking at your commits now.

@XanderRubio
Update README.md
9f85a58 
edited the 'issues closed' and "PRs closed" URL for the img.shields to the Before I Die repo address
@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Aug 24, 2023 •
edited
Loading

Great! Looks excellent with the addition, and we just needed to add the correct URL address of the Before I Die Code repo for the badges of issues closed and pull requests pulled to be linked to our repo info.

[![issues closed](https://img.shields.io/github/issues-closed/BeforeIDieCode/BeforeIDieAchievements)](https://github.com/BeforeIDieCode/BeforeIDieAchievements/issues) [![PRs closed](https://img.shields.io/github/issues-pr-closed/BeforeIDieCode/BeforeIDieAchievements)](https://github.com/BeforeIDieCode/BeforeIDieAchievements/pulls)

Thank you, Viktorius! for acting right away on this issue! Please go ahead and star ⭐️ this repository and also add your text and image to the Before I Die website in addition, add your name to the Contributor.md and you have contributed! Thank you again and have a great day!

#26 is now closed ✅

@XanderRubio XanderRubio linked an issue Aug 24, 2023 that may be closed by this pull request
🟢 Add README Badges #26
Closed
5 tasks
@XanderRubio XanderRubio merged commit 01a19e4 into BeforeIDieCode:main Aug 24, 2023
@viktoriussuwandi viktoriussuwandi deleted the issue#26 branch August 25, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🟢 Add README Badges

2 participants

@viktoriussuwandi @XanderRubio