Skip to content

Fix : added my BID and glassmorphism effect to card#177

Merged
XanderRubio merged 3 commits intoBeforeIDieCode:mainfrom
Jothishwar:add-jothishwar
Oct 11, 2023
Merged

Fix : added my BID and glassmorphism effect to card#177
XanderRubio merged 3 commits intoBeforeIDieCode:mainfrom
Jothishwar:add-jothishwar

Conversation

@Jothishwar
Copy link
Copy Markdown
Contributor

@Jothishwar Jothishwar commented Oct 11, 2023

Closes #5

Proposed Changes and Benefits

  • Added my Before I Die text with required images
  • Added a glassmorphism effect to the card displaying the BID text of the contributors to improve the UI

Screenshots

image

Notes to Reviewers

Checklist

  • I have thoroughly read and understand The Contribution Guidelines.
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior.
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc.
    • Fix - bug fixes.
    • Docs - fixing typos and adding new content.
  • I have listed my proposed changes and their benefits.
  • I have linked the corresponding issue in the Issues section.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2023

@Jothishwar is attempting to deploy a commit to the Before I Die Code Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
before-i-die-achievements ❌ Failed (Inspect) Oct 11, 2023 11:52am

XanderRubio
XanderRubio reviewed Oct 11, 2023
View reviewed changes
Comment thread src/Components/MasonryLayout/MasonryBox/MasonryBox.module.css
Copy link
Copy Markdown
Member

@XanderRubio XanderRubio Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat, and great job adding this glass effect. It looks beautiful!

XanderRubio
XanderRubio approved these changes Oct 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@XanderRubio XanderRubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Jothishwar! It looks great and shows up great when viewing your work on the local dev server. We are currently having issues with dependencies affecting the preview link. I am going to see what happens when I merge your changes including the dependencies you added, as I recently deleted the package-lock.json, and this caused an issue that we now have ever since when attempting to run the preview deployment. I just wanted to let you know.

Thank you for taking the time to assist and add value to the UI, additionally sharing what you want to do before you die, and providing as much as you can for your parents.

@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Oct 11, 2023

@Jothishwar I may need to revert this merge and address the dependency issue we are currently facing, but not the less we will get your contribution in the main branch.

@XanderRubio XanderRubio merged commit 5c3da22 into BeforeIDieCode:main Oct 11, 2023
@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Oct 11, 2023

@Jothishwar, Your pull request has been successfully merged!!! Congratulations Bottle with Popping CorkBottle with Popping CorkBottle with Popping CorkDouble Exclamation MarkDouble Exclamation MarkDouble Exclamation Mark. I wish you all the best in your pursuit to live a life of purpose and giving back to your parents and traveling the world!

If you haven't already, please go ahead and star Glowing StarGlowing StarGlowing Starthis repo and you are more than welcome to continually contribute to this project by assisting with our open issues, or adding your own new open issues, and additionally you can get an idea of ideas we have to continually grow this project further as technology and tech stack continually evolve by looking at the ROADMAP for the project. Have a great day, and thank you for taking the time to contribute, JOTHISHWAR! You can view your contribution now on the live link. Have a great rest of your day, and I will be sending you an invite to be a member of the Before I Die Code now.

@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Oct 11, 2023

I would like to apologize, @Jothishwar, for the delay and the unsmooth way we operate. I am sorry for not having shared the preview link with you earlier so that you could see your work. This happened because I made a mistake that led to dependency errors in the repository. This affected our ability to deploy, but it has been sorted out now.

I want to express my gratitude for your contribution and enhancement of the UI. You are always welcome to contribute to this repository. However, I request that you create an issue first and wait to get assigned before creating your pull request. This is for organizational purposes.

Thank you very much for your assistance and for helping to grow this project further! YOUR CONTRIBUTION CAN BE VIEWED ON THE LIVE LINK NOW

Thank you,

Xander

@Jothishwar
Copy link
Copy Markdown
Contributor Author

Jothishwar commented Oct 12, 2023

I would like to apologize, @Jothishwar, for the delay and the unsmooth way we operate. I am sorry for not having shared the preview link with you earlier so that you could see your work. This happened because I made a mistake that led to dependency errors in the repository. This affected our ability to deploy, but it has been sorted out now.

I want to express my gratitude for your contribution and enhancement of the UI. You are always welcome to contribute to this repository. However, I request that you create an issue first and wait to get assigned before creating your pull request. This is for organizational purposes.

Thank you very much for your assistance and for helping to grow this project further! YOUR CONTRIBUTION CAN BE VIEWED ON THE LIVE LINK NOW

Thank you,

Xander

@XanderRubio Its okay, things like this happen once in a while. I'm happy that the issue is resolved now and my PR is merged. Looking forward to contribute more.

Thank you ✌️

@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Oct 12, 2023

I would like to apologize, @Jothishwar, for the delay and the unsmooth way we operate. I am sorry for not having shared the preview link with you earlier so that you could see your work. This happened because I made a mistake that led to dependency errors in the repository. This affected our ability to deploy, but it has been sorted out now.
I want to express my gratitude for your contribution and enhancement of the UI. You are always welcome to contribute to this repository. However, I request that you create an issue first and wait to get assigned before creating your pull request. This is for organizational purposes.
Thank you very much for your assistance and for helping to grow this project further! YOUR CONTRIBUTION CAN BE VIEWED ON THE LIVE LINK NOW
Thank you,
Xander

@XanderRubio Its okay, things like this happen once in a while. I'm happy that the issue is resolved now and my PR is merged. Looking forward to contribute more.

Thank you ✌️

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XanderRubio XanderRubio XanderRubio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1️⃣ Make your mark: Contribute to our project and help us create a platform for documenting life goals and aspirations!

2 participants

@Jothishwar @XanderRubio