Skip to content

'Feature' / Closes #45 #133

Merged
XanderRubio merged 113 commits intoBeforeIDieCode:feature-dummy_imagefrom
negar-75:feature-dummy_image
Sep 24, 2023
Merged

'Feature' / Closes #45 #133
XanderRubio merged 113 commits intoBeforeIDieCode:feature-dummy_imagefrom
negar-75:feature-dummy_image

Conversation

@negar-75
Copy link
Copy Markdown
Contributor

this is an updated version now we can merge it and in future we ca expand this with more features.

XanderRubio and others added 30 commits August 30, 2023 18:28
Changing the color of span style to #FFE439 for the Typewriter element
… resource in the ROADMAP to reference later.
Updating the cormat of a contributors avatar naming path and adding a…
Renamed the start and end number columns for contributors Hanny and Negar.
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
before-i-die-achievements ✅ Ready (Inspect) Visit Preview Sep 24, 2023 7:52am

@XanderRubio
Copy link
Copy Markdown
Member

XanderRubio commented Sep 24, 2023

Hi @negar-75! Great job splitting the header and laying it out! I like how the preview link turned out🙏🏻 I'm going to merge the feature branch and into the main branch later. We can expand on it in the future, and your contribution to the front-end has opened up many possibilities. Thank you for your time and effort! I'll review the code later today to better understand how you did it. I appreciate your UI addition and the animated image effect. The color of the images now matches the text in the other header, and it's great that you added the "GitHub Repo" on the other side of the header. I am grateful for sharing your talent and contribution. You will be hearing back from me later today😇 Have a great Sunday!

@XanderRubio XanderRubio merged commit 4c8ec05 into BeforeIDieCode:feature-dummy_image Sep 24, 2023
@XanderRubio
Copy link
Copy Markdown
Member

Adding to the feature-dummy_image branch and will close issue #45 after merged into the main branch

@negar-75
Copy link
Copy Markdown
Contributor Author

Hi @XanderRubio
I hope you've had a great night
thanks a lot for everything

@XanderRubio
Copy link
Copy Markdown
Member

Hi @XanderRubio I hope you've had a great night thanks a lot for everything

My pleasure @negar-75 and thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.