feat: add minimal docker image build support and remove dashboard bui…#7424
Open
404MaximWang wants to merge 3 commits intoAstrBotDevs:masterfrom
Open
feat: add minimal docker image build support and remove dashboard bui…#7424404MaximWang wants to merge 3 commits intoAstrBotDevs:masterfrom
404MaximWang wants to merge 3 commits intoAstrBotDevs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
strategy.matrixdefinitions forbuild-nightly-imageandbuild-release-imageare duplicated; consider extracting the matrix values (e.g., via YAML anchors or a reusable workflow input) to avoid divergence if the set of image types changes in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `strategy.matrix` definitions for `build-nightly-image` and `build-release-image` are duplicated; consider extracting the matrix values (e.g., via YAML anchors or a reusable workflow input) to avoid divergence if the set of image types changes in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a minimal multi-stage Dockerfile for AstrBot. The review identifies several critical improvements: copying the entire /usr/local/bin directory is risky and should be scoped, the pip installation commands can be consolidated into a single layer, the runtime dependency installation is largely redundant, and the cleanup of Python cache files should be handled via .dockerignore to effectively reduce image size.
…etter robustness; deduplicate 'uv pip install' command; remove useless 'apt install' and 'find' commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 动机
Provide a more lightweight Docker image.
提供更加轻量的镜像。
Remove redundant dashboard compilation steps in the workflow.
移除无用的Dashboard编译工作。
Modifications / 改动点
Updated
.github/workflows/docker-image.ymlto remove unused dashboard build steps as the build artifacts were excluded by.dockerignoreanyway.Added
Dockerfile.minimaland updated the workflow to support building minimal images.更改了.github/workflows/docker-image.yml；新增了Dockerfile.minimal
原docker-image.yml文件包含了编译dashboard的内容，然而编译结果的存放路径被列在.dockerignore文件中，也即编译结果不会被打包。本次修改移除了此内容。
增加了minimal镜像的打包工作流以提供更加轻量的镜像。
Screenshots or Test Results / 运行截图或测试结果
The result of local packaging is shown in the figure. The image size is significantly reduced.
本地打包得到的结果如图。镜像体积显著减小。
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能，已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试，并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库，或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Add support for building and publishing both standard and minimal Docker images while simplifying the Docker image workflows.
Enhancements:
CI: