Skip to content

fix: pop_record() preserves tool_calls/tool pairing to prevent 400 error on context overflow #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CompilError-bts wants to merge 9 commits into
base: master
Choose a base branch
from
+160 −22
Open

fix: pop_record() preserves tool_calls/tool pairing to prevent 400 error on context overflow #7232

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a255792
fix: keep tool call message pairs when trimming context
CompilError-bts Mar 31, 2026
a3aed9b
test: add regression coverage for pop_record truncation
CompilError-bts Mar 31, 2026
a844133
test: make file URI tests cross-platform
CompilError-bts Mar 31, 2026
2cd9a49
Merge pull request #1 from CompilError-bts/codex/implement-fix-from-i…
CompilError-bts Mar 31, 2026
cd613e6
refactor: deduplicate unit range detection in pop_record
CompilError-bts Mar 31, 2026
82c70b5
Merge branch 'master' into codex/implement-fix-from-issue-7225-fwjo6t
CompilError-bts Mar 31, 2026
592a753
Merge pull request #2 from CompilError-bts/codex/implement-fix-from-i…
CompilError-bts Mar 31, 2026
a90f480
refactor: clarify pop_record removal policy constants
CompilError-bts Mar 31, 2026
c8d428b
Merge pull request #4 from CompilError-bts/codex/refactor-removal-loo…
CompilError-bts Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: make file URI tests cross-platform
  • Loading branch information
@CompilError-bts
CompilError-bts committed Mar 31, 2026
commit a844133e56a4f7acdb24a8a6632f87211e50c5ff
22 changes: 12 additions & 10 deletions tests/test_openai_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from types import SimpleNamespace
from pathlib import Path
from urllib.parse import urlparse, urlunparse

import pytest
from openai.types.chat.chat_completion import ChatCompletion
Expand Down Expand Up @@ -888,9 +890,8 @@ async def test_prepare_chat_payload_materializes_context_file_uri_image_urls(tmp
async def test_file_uri_to_path_preserves_windows_drive_letter():
provider = _make_provider()
try:
assert provider._file_uri_to_path("file:///C:/tmp/quoted-image.png") == (
"C:/tmp/quoted-image.png"
)
resolved = provider._file_uri_to_path("file:///C:/tmp/quoted-image.png")
assert Path(resolved) == Path("C:/tmp/quoted-image.png")
finally:
await provider.terminate()

Expand All @@ -899,9 +900,8 @@ async def test_file_uri_to_path_preserves_windows_drive_letter():
async def test_file_uri_to_path_preserves_windows_netloc_drive_letter():
provider = _make_provider()
try:
assert provider._file_uri_to_path("file://C:/tmp/quoted-image.png") == (
"C:/tmp/quoted-image.png"
)
resolved = provider._file_uri_to_path("file://C:/tmp/quoted-image.png")
assert Path(resolved) == Path("C:/tmp/quoted-image.png")
finally:
await provider.terminate()

Expand All @@ -910,9 +910,8 @@ async def test_file_uri_to_path_preserves_windows_netloc_drive_letter():
async def test_file_uri_to_path_preserves_remote_netloc_as_unc_path():
provider = _make_provider()
try:
assert provider._file_uri_to_path("file://server/share/quoted-image.png") == (
"//server/share/quoted-image.png"
)
resolved = provider._file_uri_to_path("file://server/share/quoted-image.png")
assert Path(resolved) == Path("//server/share/quoted-image.png")
finally:
await provider.terminate()

Expand Down Expand Up @@ -1083,7 +1082,10 @@ async def test_prepare_chat_payload_materializes_context_localhost_file_uri_imag
image_path = tmp_path / "quoted-image.png"
PILImage.new("RGBA", (1, 1), (255, 0, 0, 255)).save(image_path)

localhost_uri = f"file://localhost{image_path.as_posix()}"
parsed_local_uri = urlparse(image_path.as_uri())
localhost_uri = urlunparse(
("file", "localhost", parsed_local_uri.path, "", "", "")
)
payloads, _ = await provider._prepare_chat_payload(
prompt=None,
contexts=[
Expand Down