Skip to content

[Implement] Naive Buffer.from, and friends #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtenner wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[Implement] Naive Buffer.from, and friends #6

Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
62b4dc9
[Implement] Naive Buffer.from
jtenner Jul 19, 2019
3b67754
[Cleanup] remove log function
jtenner Jul 20, 2019
c2a6432
[Cleanup] add T extends ArrayBufferView to squelch intellisense
jtenner Jul 20, 2019
daf9dc1
[Chore] merge master
jtenner Jul 23, 2019
ba78bc9
Merge branch 'from' of https://github.com/AssemblyScript/node into from
jtenner Jul 23, 2019
66af315
Merge branch 'master' of https://github.com/AssemblyScript/node into …
jtenner Aug 6, 2019
cc536a0
[merge] from master
jtenner Aug 6, 2019
c6997e1
[Fix] array of strings implementation
jtenner Aug 6, 2019
a333399
Merge branch 'master' of https://github.com/assemblyscript/node into …
jtenner Aug 21, 2019
45a61c5
[Implement] rest of buffer.from functions per dcode
jtenner Aug 22, 2019
a05852d
merge master, add helper assembleBuffer function, fix tests
jtenner Mar 13, 2020
7f69832
remove type info
jtenner Mar 13, 2020
92c303d
Merge branch 'master' of https://github.com/assemblyscript/node into …
jtenner Mar 13, 2020
11be548
add ascii encoding
jtenner Mar 13, 2020
7f3e8c2
rename to allocBuffer
jtenner Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assembly/buffer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class Buffer extends Uint8Array {
}

// @ts-ignore: Buffer returns on all valid branches
public static from<T>(value: T): Buffer {
public static from<T extends ArrayBufferView>(value: T): Buffer {
// @ts-ignore: AssemblyScript treats this statement correctly
if (value instanceof String[]) {
let length = value.length;
Expand Down