Skip to content

[Implement] Buffer#inspect #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtenner wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[Implement] Buffer#inspect #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
99b14a8
[Implement] Buffer#concat (todo: fix tlsf problem)
jtenner Jul 22, 2019
8812172
[Fix] Clean up inspect implementation
jtenner Jul 23, 2019
01d079b
[Fix] Edge case when length = 0, todo: more optimization
jtenner Jul 23, 2019
10a5c54
[Chore] switch to global
jtenner Jul 23, 2019
fe0cf50
[Chore] Merge master
jtenner Jul 23, 2019
f418fd0
[Optimize] memory.copy parameters with global strings
jtenner Jul 23, 2019
cea7473
[Merge] master, use Hex encoding method
jtenner Aug 1, 2019
e5f6e4a
Merge branch 'master' into inspect
jtenner Aug 6, 2019
628562c
[Fix] switch to hex
jtenner Aug 6, 2019
b956d5e
[Fix] types merge problem
jtenner Aug 6, 2019
e8afe85
[fix] example
jtenner Aug 6, 2019
b9ed343
[chore] remove unecessary comment
jtenner Aug 6, 2019
a5579cb
[fix] nit remove parenthesis
jtenner Aug 6, 2019
11cc4d3
[fix] remove type annotation
jtenner Aug 6, 2019
a00145c
[test] use create convenience method instead
jtenner Aug 6, 2019
ef7e34e
[fix] switch to known constant
jtenner Aug 6, 2019
5fe8a7f
[fix] add BUFFER_INSPECT_HEADER_BYTE_LEN constant
jtenner Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Optimize] memory.copy parameters with global strings
  • Loading branch information
@jtenner
jtenner committed Jul 23, 2019
commit f418fd039eea0e51a0d679eb46c3f31405973274
10 changes: 6 additions & 4 deletions assembly/buffer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { BLOCK_MAXSIZE } from "rt/common";
import { BLOCK_MAXSIZE, BLOCK, BLOCK_OVERHEAD } from "rt/common";
import { E_INVALIDLENGTH, E_INDEXOUTOFRANGE } from "util/error";
import { Uint8Array } from "typedarray";

const BUFFER_INSPECT_HEADER_START: string = "<Buffer ";

export let INSPECT_MAX_BYTES: i32 = 50;
Expand Down Expand Up @@ -73,8 +72,11 @@ export class Buffer extends Uint8Array {
let result = __alloc(stringLength << 1, idof<String>());

// copy the 16 "<Buffer " bytes
let source = "<Buffer ";
memory.copy(result, changetype<usize>(source), 16);
memory.copy(
result,
changetype<usize>(BUFFER_INSPECT_HEADER_START),
changetype<BLOCK>(changetype<usize>(BUFFER_INSPECT_HEADER_START) - BLOCK_OVERHEAD).rtSize,
);

// Start writing at index 8
let writeOffset: usize = result + 16;
Expand Down
4 changes: 1 addition & 3 deletions tests/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,7 @@ function runTest(file, type, binary, wat) {
+ "." + type + ".wat";

// should not block testing
fs.writeFile(watPath, wat, (err) => {
if (err) console.warn(err);
});
fs.writeFileSync(watPath, wat);

const context = new TestContext({
fileName: file,
Expand Down