Integrate Rtrace with ESM bindings#2595
Merged
Merged
Conversation
Member
|
I spent way too long yesterday (at least two/three hours) trying to hack around ESM/raw bindings to get rtrace to work. I'm glad it's working now. Should rtrace be added to CI in case it catches errors before faulty PRs are merged? Or is this bug a special case? |
Member
Author
|
Rtrace is used for some of the tests (when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rtrace utility to inspect the inner workings of the runtime must be installed on the respective imports objects, which did not work as-is with ESM bindings
Hence, add a special case to ESM bindings generation to install Rtrace when used, exclude its imports from instrumentation, and import it with a private package specifier so it can be mapped via
importsin package.json. Also unbreaksbootstrap:rtracedin so far as that it executes.