You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed on Slack and in #1331, this PR removes our custom release logic, including publishing nightlies which isn't necessary anymore after the change, and installs semantic-release (currently configured to perform dry runs in case something goes wrong).
Commit format would then be:
fix: Message for a patch (wondering what will happen there with version < 1)
feat: Message for a minor
BREAKING CHANGE: Message (or used as a footer) for a major
Looking up the v0 problem revealed that they are apparently not handling v0.x.x as one would expect, but will bump to v1.0.0 on the next breaking change. Quite unfortunate.
Yeah, using a scope seems good. I'm however unwilling to force out a v1 just because of this. Now one could argue that version numbers are arbitrary anyway, but I guess if there is a case to be made about something being "not quite ready" to be a v1.0.0, then it's in tech like WebAssembly, so I'd like to stick to v0.x.x for now.
Now uses my fork of semantic-release that has a --unstable command line option enforcing releases to stay in the v0.x.y range. Turned out this can be achieved with just a few lines of code.
dcodeIO
changed the title
Set up semantic release
chore: Set up semantic release
Jun 13, 2020
Merging, but letting it perform dry runs initially so I can check the logs, hence no actual releases just yet. Going to activate once sufficiently confident that it's working :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Slack and in #1331, this PR removes our custom release logic, including publishing nightlies which isn't necessary anymore after the change, and installs semantic-release (currently configured to perform dry runs in case something goes wrong).
Commit format would then be:
fix: Messagefor a patch (wondering what will happen there with version < 1)feat: Messagefor a minorBREAKING CHANGE: Message(or used as a footer) for a major