Additional Event Firing Fix#1
Closed
the-c0d3r wants to merge 1 commit intoAqsa-K:masterfrom
the-c0d3r:patch-1
Closed
Additional Event Firing Fix#1the-c0d3r wants to merge 1 commit intoAqsa-K:masterfrom the-c0d3r:patch-1
the-c0d3r wants to merge 1 commit intoAqsa-K:masterfrom
the-c0d3r:patch-1
Conversation
I tested the code and it seem like the event streaming is fired as soon as you start the stream on a reference which already have data in the database. Therefore I modified the code to check for the `last_value` and only fire the event if the value is changed. I modified this to fit my needs, maybe somebody will find this useful as well. Thanks for your commit adding the SSE client.
Author
|
Since this feature has been merged into Firebase, I will be closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested the code and it seem like the event streaming is fired as soon as you start the stream on a reference which already have data in the database. Therefore I modified the code to check for the
last_valueand only fire the event if the value is changed. I modified this to fit my needs, maybe somebody will find this useful as well. Thanks for your commit adding the SSE client.Original comment from this discussion
I tried your fork repo, somehow it fires off an event as soon as I set the stream() and the callback function is called immediately. But the intended listening event is triggered every time when the data is changed in the database side.
Is it possible to fix this unexpected behavior? I would like to help fix it, but I have no idea where to start looking and I have never worked with SSE before. If anyone can point me in correct direction, please do.