packages/opencode/test/altimate/tool-label.test.ts (1)

31-35: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Consider adding a case for list on a nested dbt subdirectory.

The existing case only covers a top-level directory ({ path: "models" }). A case like { path: "models/staging" } would have caught the mislabeling issue flagged in tool-label.ts (friendlyTarget applying the dbt "model" suffix to a directory name).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/opencode/test/altimate/tool-label.test.ts` around lines 31 - 35, Add
a test in tool-label.test.ts for describeToolCall("list", ...) using a nested
dbt subdirectory target like models/staging, since the current list case only
covers the top-level models path and misses the friendlyTarget mislabeling in
tool-label.ts. Update the test set so it asserts the nested directory is labeled
correctly (without the dbt “model” suffix), keeping the existing glob/grep/list
coverage intact.

packages/opencode/src/altimate/tool-label.ts (1)

41-71: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

list on a nested dbt subdirectory produces a misleading "model" label.

friendlyTarget strips extensions and appends the dbt "kind" noun whenever any ancestor segment matches DBT_DIR_KIND, regardless of whether the target is a file or a directory. This works fine for read/write/edit (always files) but for list the target is always a directory, so listing a nested dbt folder is mislabeled as if it were a single model:

• describeToolCall("list", { path: "models" }, ...) → "Listing models" (correct, top-level dir has no ancestor match)
• describeToolCall("list", { path: "models/staging" }, ...) → "Listing staging model" (wrong — this is a directory of many models, not one model)

Consider skipping the dbt kind-suffix rewrite for list, or only applying it when the base segment has a recognized dbt file extension (sql/yaml/csv).

💡 Possible fix

 function friendlyTarget(rawPath: string): string {
   const segments = rawPath.replace(/\\/g, "/").replace(/^\.\//, "").split("/").filter(Boolean)
   const base = segments[segments.length - 1] ?? rawPath
   for (const segment of segments.slice(0, -1)) {
     const kind = DBT_DIR_KIND[segment.toLowerCase()]
-    if (kind) {
+    if (kind && /\.(sql|ya?ml|csv)$/i.test(base)) {
       const name = base.replace(/\.(sql|ya?ml|csv)$/i, "")
       return `${name} ${kind}`
     }
   }
   return base
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/opencode/src/altimate/tool-label.ts` around lines 41 - 71, The
`list` tool is incorrectly reusing `friendlyTarget`, which adds a dbt kind
suffix for any path with a dbt ancestor and makes directory listings like nested
folders look like a single model. Update `fileTarget` so the `list` branch does
not apply the file-oriented `friendlyTarget` rewrite, or make `friendlyTarget`
only append the dbt kind when the target is a file with a recognized dbt
extension. Keep the existing behavior for `read`/`write`/`edit`/`multiedit`, and
verify `describeToolCall("list", ...)` produces directory names without
misleading model labels.

1. packages/opencode/src/altimate/tool-label.ts (L49-L50)

[🟠 MEDIUM] Iterating left-to-right (from the root down) can incorrectly match an outer directory that coincidentally shares a name with a dbt folder, rather than the intended specific directory (e.g., an absolute path like /Users/user/models/my_project/macros/utils.sql would match models instead of macros, returning utils model instead of utils macro).

Consider iterating right-to-left (from the file upwards) to match the most specific parent directory.

Suggested change:

  for (let i = segments.length - 2; i >= 0; i--) {
    const segment = segments[i]
    const kind = DBT_DIR_KIND[segment.toLowerCase()]

2. packages/opencode/src/altimate/tool-label.ts (L51-L54)

[🟠 MEDIUM] The regex misses .py (for Python models) and .md (for dbt documentation files), which are both common in dbt projects. Without these, a Python model would render as model.py model rather than model model. Consider adding them to the regex.

Suggested change:

    if (kind) {
      const name = base.replace(/\.(sql|ya?ml|csv|py|md)$/i, "")
      return `${name} ${kind}`
    }

3. packages/opencode/src/altimate/tool-label.ts

[🔵 LOW] FILE_TOOL_VERBS and DBT_DIR_KIND are plain objects. Looking up a string like constructor or toString could hit inherited Object.prototype properties, leading to unexpected string values in the label.

Consider using Object.assign(Object.create(null), {...}) to safely initialize these dictionaries without prototypes.

Suggested change:

const FILE_TOOL_VERBS: Record<string, string> = Object.assign(Object.create(null), {
  read: "Reading",
  write: "Writing",
  edit: "Editing",
  multiedit: "Editing",
  glob: "Searching",
  grep: "Searching",
  list: "Listing",
})

/** dbt directory → singular noun used in the label. */
const DBT_DIR_KIND: Record<string, string> = Object.assign(Object.create(null), {
  models: "model",
  seeds: "seed",
  macros: "macro",
  snapshots: "snapshot",
  tests: "test",
  analyses: "analysis",
  analysis: "analysis",
})