[pull] main from dotnet:main#1336
Merged
Merged
Conversation
## Summary Matching PR for dotnet/runtime#125231, which fixes `DefaultCOMImpl::Release()` reference counting bugs in the DAC. ### Changes **1. Fix `SOSMethodEnum` simulator COM ref counting** (`util.cpp`) The `SOSDacInterface15` simulator's `GetMethodTableSlotEnumerator` had the same bug pattern fixed in the runtime PR — raw pointer assignment without `QueryInterface`, and the null check occurred after the dereference. Fixed to: - Initialize `refCount` to 0 (matching `DefaultCOMImpl` convention) - Use `QueryInterface` to return the interface, properly calling `AddRef` - Check for null before dereferencing the out parameter - Use `delete` on failure (since `QueryInterface` wasn't called at refCount 0) **2. Fix `ISOSMethodEnum` leak in `strike.cpp`** Changed raw `ISOSMethodEnum*` to `ToRelease<ISOSMethodEnum>` so `Release()` is called when the pointer goes out of scope, matching the pattern used everywhere else (e.g., `ToRelease<ISOSHandleEnum>`). Co-authored-by: Max Charlamb <maxcharlamb@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
On Linux, the in-framework Console.CursorVisible getter always throws PlatformNotSupportedException while the setter works via ANSI escape codes. The collect-linux command was reading Console.CursorVisible to save and restore cursor state, which caused an unhandled exception on every invocation. Since the tests were mocking console, nothing got caught. The getter is unsupported on Linux (the only platform collect-linux runs on) - the most sensible thing was to remove the read entirely and always restore cursor visibility to true on exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )