Skip to content

Commit b3c9753

Browse files
andiwandandiwand
authored
build: Toggle default off for covfie, detray, vecmem (acts-project#5504)
Having `ACTS_SETUP_COVFIE`, `ACTS_SETUP_DETRAY`, and `ACTS_SETUP_VECMEM` on by default causes various problems downstream. I propose to turn them off by default until these issues are resolved
1 parent 5f15b52 commit b3c9753

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

‎CMakeLists.txt‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ option(ACTS_USE_SYSTEM_LIBS "Use system libraries by default" OFF)
6363
# plugins related options
6464
option(ACTS_USE_SYSTEM_ACTSVG "Use the ActSVG system library" ${ACTS_USE_SYSTEM_LIBS})
6565
option(ACTS_USE_SYSTEM_COVFIE "Use a system-provided covfie installation" ${ACTS_USE_SYSTEM_LIBS})
66-
option(ACTS_SETUP_COVFIE "If we want to set up covfie" ON)
67-
option(ACTS_SETUP_DETRAY "If we want to set up detray" ON)
66+
option(ACTS_SETUP_COVFIE "If we want to set up covfie" OFF)
67+
option(ACTS_SETUP_DETRAY "If we want to set up detray" OFF)
6868
option(ACTS_USE_SYSTEM_VECMEM "Use a system-provided vecmem installation" ${ACTS_USE_SYSTEM_LIBS})
69-
option(ACTS_SETUP_VECMEM "If we want to set up vecmem" ON)
69+
option(ACTS_SETUP_VECMEM "If we want to set up vecmem" OFF)
7070
option(ACTS_USE_SYSTEM_TRACCC "Use a system-provided traccc installation" ${ACTS_USE_SYSTEM_LIBS})
7171
option(ACTS_USE_SYSTEM_NLOHMANN_JSON "Use nlohmann::json provided by the system instead of the bundled version" ${ACTS_USE_SYSTEM_LIBS})
7272
option(ACTS_USE_SYSTEM_PYBIND11 "Use a system installation of pybind11" ${ACTS_USE_SYSTEM_LIBS} )
@@ -233,6 +233,7 @@ set_option_if(ACTS_BUILD_TRACCC ACTS_BUILD_PLUGIN_TRACCC)
233233
set_option_if(ACTS_BUILD_PLUGIN_JSON ACTS_BUILD_TRACCC)
234234
set_option_if(ACTS_SETUP_DETRAY ACTS_BUILD_TRACCC)
235235
set_option_if(ACTS_SETUP_VECMEM ACTS_SETUP_DETRAY)
236+
set_option_if(ACTS_SETUP_COVFIE ACTS_SETUP_DETRAY)
236237
set_option_if(ACTS_BUILD_PLUGIN_ACTSVG ACTS_SETUP_DETRAY)
237238

238239
# feature tests

‎docs/pages/contributing/building_acts.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,10 @@ components.
255255
| ACTS_USE_SYSTEM_LIBS | Use system libraries by default<br> type: `bool`, default: `OFF` |
256256
| ACTS_USE_SYSTEM_ACTSVG | Use the ActSVG system library<br> type: `bool`, default: `ACTS_USE_SYSTEM_LIBS -> OFF` |
257257
| ACTS_USE_SYSTEM_COVFIE | Use a system-provided covfie<br>installation<br> type: `bool`, default: `ACTS_USE_SYSTEM_LIBS -> OFF` |
258-
| ACTS_SETUP_COVFIE | If we want to set up covfie<br> type: `bool`, default: `ON` |
259-
| ACTS_SETUP_DETRAY | If we want to set up detray<br> type: `bool`, default: `ON` |
258+
| ACTS_SETUP_COVFIE | If we want to set up covfie<br> type: `bool`, default: `OFF` |
259+
| ACTS_SETUP_DETRAY | If we want to set up detray<br> type: `bool`, default: `OFF` |
260260
| ACTS_USE_SYSTEM_VECMEM | Use a system-provided vecmem<br>installation<br> type: `bool`, default: `ACTS_USE_SYSTEM_LIBS -> OFF` |
261-
| ACTS_SETUP_VECMEM | If we want to set up vecmem<br> type: `bool`, default: `ON` |
261+
| ACTS_SETUP_VECMEM | If we want to set up vecmem<br> type: `bool`, default: `OFF` |
262262
| ACTS_USE_SYSTEM_TRACCC | Use a system-provided traccc<br>installation<br> type: `bool`, default: `ACTS_USE_SYSTEM_LIBS -> OFF` |
263263
| ACTS_USE_SYSTEM_NLOHMANN_JSON | Use nlohmann::json provided by the<br>system instead of the bundled version<br> type: `bool`, default: `ACTS_USE_SYSTEM_LIBS -> OFF` |
264264
| ACTS_USE_SYSTEM_PYBIND11 | Use a system installation of pybind11<br> type: `bool`, default: `ACTS_USE_SYSTEM_LIBS -> OFF` |

0 commit comments

Comments
 (0)