Skip to content

[OGUI-1898] Move to async and always check for JWT token validity#3473

Merged
graduta merged 1 commit into
devfrom
improv/FRM/OGUI-1898-refactor-in-using-async-to-improve-readability
May 25, 2026
Merged

[OGUI-1898] Move to async and always check for JWT token validity#3473
graduta merged 1 commit into
devfrom
improv/FRM/OGUI-1898-refactor-in-using-async-to-improve-readability

Conversation

@graduta
Copy link
Copy Markdown
Member

@graduta graduta commented May 25, 2026

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • the lack of use of async/await was making the code difficult to read and maintain which can end up in issues such as the fixed one
  • filter command was not checking the token validity before setting it to the client in-memory filter object which means any client could bypass for a very small amount of time the check and apply anything, potentially malicious, into the filter


// Set filter only after auth is verified
if (parsed.getCommand() === RESERVED_BIND_NAME && parsed.getPayload()) {
client.filter = new Function(`return ${parsed.getPayload()}`)();
@graduta graduta merged commit a3eb14f into dev May 25, 2026
14 of 15 checks passed
@graduta graduta deleted the improv/FRM/OGUI-1898-refactor-in-using-async-to-improve-readability branch May 25, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants