Skip to content

[OGUI-1897] Replace deprecated function url.parse and replace hardcoded strings and numbers in WS server#3472

Merged
graduta merged 2 commits into
devfrom
improv/FRM/OGUI-1897-replace-deprecated-function
May 25, 2026
Merged

[OGUI-1897] Replace deprecated function url.parse and replace hardcoded strings and numbers in WS server#3472
graduta merged 2 commits into
devfrom
improv/FRM/OGUI-1897-replace-deprecated-function

Conversation

@graduta
Copy link
Copy Markdown
Member

@graduta graduta commented May 25, 2026

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • removes the use of url.parse as it is deprecated and bounded to be removed. Instead use the recommended new URL class
  • replace use of magic-number 1008 for terminating websocket connection with self-explanatory variable name
  • replace use of hard-coded strings for AUTH command with self-explanatory variable name
  • initialize isAlive with true on new connections

@graduta graduta self-assigned this May 25, 2026
@graduta graduta merged commit 2cbf30f into dev May 25, 2026
36 of 43 checks passed
@graduta graduta deleted the improv/FRM/OGUI-1897-replace-deprecated-function branch May 25, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@graduta graduta

Labels

Backend Framework

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@graduta