Skip to content

[OGUI-1188] Do not send a WS message if client connection is closing #3471

Merged
graduta merged 5 commits into
devfrom
bug/FRM/OGUI-1188-ensure-message-on-ws-not-sent-on-closing-stage
May 25, 2026
Merged

[OGUI-1188] Do not send a WS message if client connection is closing #3471
graduta merged 5 commits into
devfrom
bug/FRM/OGUI-1188-ensure-message-on-ws-not-sent-on-closing-stage

Conversation

@graduta
Copy link
Copy Markdown
Member

@graduta graduta commented May 25, 2026

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • fixes an issue in which the broadcast, send, unfilteredBroadcast would log an error on WS server due to attempting to send a message to a client that already started the terminate connection stage
  • error message: WebSocket is not open: readyState 2 (CLOSING)
  • the bug was happening because while the closing state is happening, the client still appears in client list.
  • by using the client state which gets updated on immediate call of terminate, we can better know which client to still respond to
  • rename callbackArray and initialize in a Map as per its actual use in the server
  • add input validation to bind method to ensure overriding of server bindings is not happening

@graduta graduta merged commit c9344c8 into dev May 25, 2026
25 of 29 checks passed
@graduta graduta deleted the bug/FRM/OGUI-1188-ensure-message-on-ws-not-sent-on-closing-stage branch May 25, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant