Move the QOs to TRFC conversion to a class, so it can be tested#674
Merged
knopers8 merged 2 commits intoApr 19, 2021
Merged
Conversation
knopers8
force-pushed
the
assign-reasons-to-qualities
branch
from
April 16, 2021 08:22
ddc127b to
c311c01
Compare
Collaborator
|
the build errors are legit |
Collaborator
Author
|
Oh, indeed. I forgot that I need a PR to O2 first. |
Collaborator
Author
|
It'll go after this AliceO2Group/AliceO2#5941 |
knopers8
force-pushed
the
assign-reasons-to-qualities
branch
from
April 16, 2021 11:39
c311c01 to
68b8478
Compare
knopers8
force-pushed
the
assign-reasons-to-qualities
branch
from
April 16, 2021 11:40
68b8478 to
854f644
Compare
Barthelemy
approved these changes
Apr 19, 2021
Barthelemy
left a comment
Collaborator
There was a problem hiding this comment.
Clean and very clear code. Just 2 questions but nothing blocking at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #673