Skip to content

[Common,DPG,PWGEM,PWGHF,PWGLF] Fix PID include paths - #17451

Open
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:pid
Open

[Common,DPG,PWGEM,PWGHF,PWGLF] Fix PID include paths#17451
vkucera wants to merge 1 commit into
AliceO2Group:masterfrom
vkucera:pid

Conversation

@vkucera

@vkucera vkucera commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added pwghf PWG-HF pwglf common pwgem dpg photon Photon and neutral meson PAG label labels Aug 13, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 515 errors, ⚠️ 784 warnings, 🔕 11 disabled

@github-actions github-actions Bot changed the title Fix PID include paths [Common,DPG,PWGEM,PWGHF,PWGLF] Fix PID include paths Aug 13, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e203261 at 2026-08-13 20:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 385 errors and 31 warnings.'
Found 385 errors and 31 warnings.
++ [[ 385 -gt 0 ]]
++ cat /sw/BUILD/64fa9ea007794d0673d6b6df9e166d986a5d1e22/O2Physics-code-check/errors.txt
Common/Core/PID/PIDTOFParamService.cxx:49:116: error: the const qualified parameter 'task' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:73:65: error: the const qualified parameter 'task' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:137:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:215:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:288:8: error: destructor of 'TOFSupport' is public and non-virtual [cppcoreguidelines-virtual-class-destructor,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:297:29: error: use designated initializer list to initialize 'ServiceHandle' [modernize-use-designated-initializers,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:301:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
Common/Core/PID/ParamBase.cxx:42:18: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
Common/Core/PID/ParamBase.cxx:57:15: error: variable 'p' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Core/PID/ParamBase.cxx:70:23: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
Common/Core/PID/ParamBase.cxx:83:20: error: variable 'p' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:56:7: error: variable 'trackDistanceForGoodMatch' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:57:7: error: variable 'trackDistanceForGoodMatchLowMult' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:58:5: error: variable 'multiplicityThreshold' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:64:12: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:165:7: error: variable 'trackSampleMinMomentum' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:166:7: error: variable 'trackSampleMaxMomentum' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:187:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:236:26: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:240:27: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:244:25: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:248:29: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:268:32: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:281:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:290:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:310:7: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:375:84: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:437:84: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:457:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:458:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/TableProducer/PID/pidTOFBase.cxx:472:9: error: Value stored to 'weight' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:61:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:89:51: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:126:28: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:126:56: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:129:28: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:129:57: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:157:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:166:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:185:7: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/TableProducer/PID/pidTOFFull.cxx:199:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/TableProducer/PID/pidTOFMerge.cxx:79:12: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common dpg photon Photon and neutral meson PAG label pwgem pwghf PWG-HF pwglf

Development

Successfully merging this pull request may close these issues.

3 participants