Skip to content

[PWGCF] Refactor lambda spin polarization histogram setup#17169

Open
subhadee-ali wants to merge 2 commits into
AliceO2Group:masterfrom
subhadee-ali:lambdaspinCorr
Open

[PWGCF] Refactor lambda spin polarization histogram setup#17169
subhadee-ali wants to merge 2 commits into
AliceO2Group:masterfrom
subhadee-ali:lambdaspinCorr

Conversation

@subhadee-ali

Copy link
Copy Markdown
Contributor

Updated bin configurations and histogram definitions for lambda spin polarization analysis. Added new methods for calculating cosThetaStar and adjusted histogram filling logic.

Updated bin configurations and histogram definitions for lambda spin polarization analysis. Added new methods for calculating cosThetaStar and adjusted histogram filling logic.
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Refactor lambda spin polarization histogram setup [PWGCF] Refactor lambda spin polarization histogram setup Jul 22, 2026
Moved variable declarations for pt, eta, rap, and phi to a different scope.
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 00b0751 at 2026-07-22 16:59:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 32 errors and 101 warnings.'
Found 32 errors and 101 warnings.
++ [[ 32 -gt 0 ]]
++ cat /sw/BUILD/f8b68325998e27426487105aa87d3aa3ff68a469/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:319:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:600:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:815:7: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:815:25: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:815:25: error: redundant explicit casting to the same type 'TObject *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:816:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:831:7: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:831:25: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:831:25: error: redundant explicit casting to the same type 'TObject *' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:832:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:860:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:898:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:899:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1201:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1270:9: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1345:5: error: function 'px' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1346:5: error: function 'py' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1347:5: error: function 'pz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1348:5: error: function 'pt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1349:5: error: function 'rap' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1350:5: error: function 'phi' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1351:5: error: function 'mass' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1352:5: error: function 'prPx' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1353:5: error: function 'prPy' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1354:5: error: function 'prPz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1519:5: error: uninitialized record type: 'vPair' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1525:5: error: uninitialized record type: 'v1p' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1525:5: error: uninitialized record type: 'v2p' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1538:5: error: uninitialized record type: 'v1lab' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1538:5: error: uninitialized record type: 'v2lab' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1549:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:1617:22: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
++ [[ 101 -gt 0 ]]
++ cat /sw/BUILD/f8b68325998e27426487105aa87d3aa3ff68a469/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:557:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:561:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:563:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:565:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:569:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:571:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:575:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/lambdaSpinPolarization.cxx:577:73: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants